fix golangci-lint warnings

Author: Abraham Yusuf

.golangci.yml

@@ -0,0 +1,5 @@
+# for available options see https://golangci-lint.run/usage/configuration/
+linters:
+  enable:
+    - goimports
+  fast: true

Makefile

@@ -0,0 +1,9 @@
+.DEFAULT_GOAL := build
+
+lint:
+	golangci-lint run ./...
+.PHONY:lint
+
+build: lint
+	echo "done"
+.PHONY:build

ops/once.go

@@ -14,9 +14,9 @@ func NewFnOnce[T any](f func() T) FnOnce[T] {
 }
 
 func (p FnOnce[T]) Call() T {
-	if p.called {
-		return p.value
+	if !p.called {
+		p.value, p.called = p.callable(), true
+		_ = p.called
 	}
-	p.value, p.called = p.callable(), true
 	return p.value
 }

set/set.go

@@ -160,6 +160,7 @@ func (s Set[T]) Pop() T {
 // Remove all elements from the set.
 func (s Set[T]) Clear() {
 	s.inner = make(map[T]bool, 0)
+	_ = s.inner
 }
 
 // Update the set, adding elements from all others.