Skip to content

Commit 584648c

Browse files
committed
Make docker-nobasepackages expand flag the default
It makes no sense to provide extra packages in the repository provided to docker that are never used.
1 parent b192f16 commit 584648c

File tree

3 files changed

+5
-18
lines changed

3 files changed

+5
-18
lines changed

Build.pm

+5-4
Original file line numberDiff line numberDiff line change
@@ -739,10 +739,11 @@ sub get_build {
739739
} else {
740740
push @deps, @{$config->{'substitute'}->{"build-packages:$buildtype"} || $subst_defaults{"build-packages:$buildtype"} || []};
741741
}
742-
if ($buildtype eq 'docker' || $buildtype eq 'kiwi') {
743-
$nobasepackages = 1 if $config->{"expandflags:$buildtype-nobasepackages"};
744-
@deps = grep {!/^kiwi-image:/} @deps if $buildtype eq 'kiwi'; # only needed for sysdeps
745-
@deps = grep {!/^kiwi-packagemanager:/} @deps if $buildtype eq 'kiwi' && $nobasepackages; # only needed for sysdeps
742+
$nobasepackages = 1 if $buildtype eq 'docker';
743+
if ($buildtype eq 'kiwi') {
744+
$nobasepackages = 1 if $config->{"expandflags:kiwi-nobasepackages"};
745+
@deps = grep {!/^kiwi-image:/} @deps; # only needed for sysdeps
746+
@deps = grep {!/^kiwi-packagemanager:/} @deps if $nobasepackages; # only needed for sysdeps
746747
}
747748
my @ndeps = grep {/^-/} @deps;
748749
my %ndeps = map {$_ => 1} @ndeps;

docs/build_config.adoc

-5
Original file line numberDiff line numberDiff line change
@@ -201,11 +201,6 @@ default, no module is used, so every module needed needs to be
201201
specified in the configuration. To remove a module, add an exclamation mark
202202
(!) as prefix.
203203

204-
* docker-nobasepackages
205-
206-
Do not put the require/support/preinstall packages in the repositories
207-
offered to the container build tool. This should have been the default.
208-
209204
* kiwi-nobasepackages
210205

211206
Do not put the require/support/preinstall packages in the repositories

docs/pbuild.html

-9
Original file line numberDiff line numberDiff line change
@@ -1338,15 +1338,6 @@ <h4 id="_expandflags_flag_value">3.2.9. ExpandFlags: FLAG[:VALUE]</h4>
13381338
<div class="ulist"><ul>
13391339
<li>
13401340
<p>
1341-
docker-nobasepackages
1342-
</p>
1343-
</li>
1344-
</ul></div>
1345-
<div class="paragraph"><p>Do not put the require/support/preinstall packages in the repositories
1346-
offered to the container build tool. This should have been the default.</p></div>
1347-
<div class="ulist"><ul>
1348-
<li>
1349-
<p>
13501341
kiwi-nobasepackages
13511342
</p>
13521343
</li>

0 commit comments

Comments
 (0)