Skip to content

Commit 194a0fc

Browse files
stephane-airbytestephane-airbyte
committed
remove all display names
1 parent 1e2971a commit 194a0fc

File tree

13 files changed

+45
-45
lines changed

13 files changed

+45
-45
lines changed

‎airbyte-cdk/java/airbyte-cdk/db-sources/src/test/java/io/airbyte/cdk/integrations/source/relationaldb/StateDecoratingIteratorTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ void testUnicodeNull() {
289289
}
290290

291291
@Test
292-
@DisplayName("When initial cursor is null, and emit state for every record")
292+
//When initial cursor is null, and emit state for every record
293293
void testStateEmissionFrequency1() {
294294
messageIterator = MoreIterators.of(RECORD_MESSAGE_1, RECORD_MESSAGE_2, RECORD_MESSAGE_3, RECORD_MESSAGE_4, RECORD_MESSAGE_5);
295295
final StateDecoratingIterator iterator1 = new StateDecoratingIterator(
@@ -320,7 +320,7 @@ void testStateEmissionFrequency1() {
320320
}
321321

322322
@Test
323-
@DisplayName("When initial cursor is null, and emit state for every 2 records")
323+
//When initial cursor is null, and emit state for every 2 records
324324
void testStateEmissionFrequency2() {
325325
messageIterator = MoreIterators.of(RECORD_MESSAGE_1, RECORD_MESSAGE_2, RECORD_MESSAGE_3, RECORD_MESSAGE_4, RECORD_MESSAGE_5);
326326
final StateDecoratingIterator iterator1 = new StateDecoratingIterator(
@@ -346,7 +346,7 @@ void testStateEmissionFrequency2() {
346346
}
347347

348348
@Test
349-
@DisplayName("When initial cursor is not null")
349+
//When initial cursor is not null
350350
void testStateEmissionWhenInitialCursorIsNotNull() {
351351
messageIterator = MoreIterators.of(RECORD_MESSAGE_2, RECORD_MESSAGE_3, RECORD_MESSAGE_4, RECORD_MESSAGE_5);
352352
final StateDecoratingIterator iterator1 = new StateDecoratingIterator(
@@ -396,7 +396,7 @@ void testStateEmissionWhenInitialCursorIsNotNull() {
396396
* <a href="https://github.com/airbytehq/airbyte/issues/15427">link</a>
397397
*/
398398
@Test
399-
@DisplayName("When there are multiple records with the same cursor value")
399+
//When there are multiple records with the same cursor value
400400
void testStateEmissionForRecordsSharingSameCursorValue() {
401401

402402
messageIterator = MoreIterators.of(

‎airbyte-cdk/java/airbyte-cdk/db-sources/src/testFixtures/java/io/airbyte/cdk/integrations/debezium/CdcSourceTest.java

+7-7
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ protected void assertExpectedRecords(final Set<JsonNode> expectedRecords,
327327
}
328328

329329
@Test
330-
@DisplayName("On the first sync, produce returns records that exist in the database.")
330+
//On the first sync, produce returns records that exist in the database.
331331
void testExistingData() throws Exception {
332332
final CdcTargetPosition targetPosition = cdcLatestTargetPosition();
333333
final AutoCloseableIterator<AirbyteMessage> read = source().read(config(), getConfiguredCatalog(), null);
@@ -351,7 +351,7 @@ protected void compareTargetPositionFromTheRecordsWithTargetPostionGeneratedBefo
351351
}
352352

353353
@Test
354-
@DisplayName("When a record is deleted, produces a deletion record.")
354+
//When a record is deleted, produces a deletion record.
355355
void testDelete() throws Exception {
356356
final AutoCloseableIterator<AirbyteMessage> read1 = source()
357357
.read(config(), getConfiguredCatalog(), null);
@@ -379,7 +379,7 @@ protected void assertExpectedStateMessagesFromIncrementalSync(final List<Airbyte
379379
}
380380

381381
@Test
382-
@DisplayName("When a record is updated, produces an update record.")
382+
//When a record is updated, produces an update record.
383383
void testUpdate() throws Exception {
384384
final String updatedModel = "Explorer";
385385
final AutoCloseableIterator<AirbyteMessage> read1 = source()
@@ -406,7 +406,7 @@ void testUpdate() throws Exception {
406406

407407
@SuppressWarnings({"BusyWait", "CodeBlock2Expr"})
408408
@Test
409-
@DisplayName("Verify that when data is inserted into the database while a sync is happening and after the first sync, it all gets replicated.")
409+
//Verify that when data is inserted into the database while a sync is happening and after the first sync, it all gets replicated.
410410
protected void testRecordsProducedDuringAndAfterSync() throws Exception {
411411

412412
final int recordsToCreate = 20;
@@ -472,7 +472,7 @@ protected void assertExpectedStateMessagesForRecordsProducedDuringAndAfterSync(f
472472
}
473473

474474
@Test
475-
@DisplayName("When both incremental CDC and full refresh are configured for different streams in a sync, the data is replicated as expected.")
475+
//When both incremental CDC and full refresh are configured for different streams in a sync, the data is replicated as expected.
476476
void testCdcAndFullRefreshInSameSync() throws Exception {
477477
final ConfiguredAirbyteCatalog configuredCatalog = Jsons.clone(getConfiguredCatalog());
478478

@@ -545,7 +545,7 @@ void testCdcAndFullRefreshInSameSync() throws Exception {
545545
}
546546

547547
@Test
548-
@DisplayName("When no records exist, no records are returned.")
548+
//When no records exist, no records are returned.
549549
void testNoData() throws Exception {
550550

551551
deleteCommand(MODELS_STREAM_NAME);
@@ -563,7 +563,7 @@ protected void assertExpectedStateMessagesForNoData(final List<AirbyteStateMessa
563563
}
564564

565565
@Test
566-
@DisplayName("When no changes have been made to the database since the previous sync, no records are returned.")
566+
//When no changes have been made to the database since the previous sync, no records are returned.
567567
void testNoDataOnSecondSync() throws Exception {
568568
final AutoCloseableIterator<AirbyteMessage> read1 = source()
569569
.read(config(), getConfiguredCatalog(), null);

‎airbyte-cdk/java/airbyte-cdk/dependencies/src/test/java/io/airbyte/api/client/AirbyteApiClientTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public class AirbyteApiClientTest {
2828
class RetryWithJitter {
2929

3030
@Test
31-
@DisplayName("Should not retry on success")
31+
//Should not retry on success
3232
void ifSucceedShouldNotRetry() throws Exception {
3333
mockCallable = mock(Callable.class);
3434
when(mockCallable.call()).thenReturn("Success!");
@@ -39,7 +39,7 @@ void ifSucceedShouldNotRetry() throws Exception {
3939
}
4040

4141
@Test
42-
@DisplayName("Should retry up to the configured max retries on continued errors")
42+
//Should retry up to the configured max retries on continued errors
4343
void onlyRetryTillMaxRetries() throws Exception {
4444
mockCallable = mock(Callable.class);
4545
when(mockCallable.call()).thenThrow(new RuntimeException("Bomb!"));
@@ -51,7 +51,7 @@ void onlyRetryTillMaxRetries() throws Exception {
5151
}
5252

5353
@Test
54-
@DisplayName("Should retry only if there are errors")
54+
//Should retry only if there are errors
5555
void onlyRetryOnErrors() throws Exception {
5656
mockCallable = mock(Callable.class);
5757
// Because we succeed on the second try, we should only call the method twice.

‎airbyte-cdk/java/airbyte-cdk/dependencies/src/test/java/io/airbyte/commons/logging/MdcScopeTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ void init() {
2323
}
2424

2525
@Test
26-
@DisplayName("The MDC context is properly overrided")
26+
//The MDC context is properly overrided
2727
void testMDCModified() {
2828
try (final MdcScope ignored = new MdcScope(modificationInMDC)) {
2929
final Map<String, String> mdcState = MDC.getCopyOfContextMap();
@@ -34,7 +34,7 @@ void testMDCModified() {
3434
}
3535

3636
@Test
37-
@DisplayName("The MDC context is properly restored")
37+
//The MDC context is properly restored
3838
void testMDCRestore() {
3939
try (final MdcScope ignored = new MdcScope(modificationInMDC)) {}
4040

‎airbyte-cdk/java/airbyte-cdk/dependencies/src/test/java/io/airbyte/configoss/helpers/YamlListToStandardDefinitionsTest.java

+12-12
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,15 @@ class YamlListToStandardDefinitionsTest {
5757
+ " documentationUrl";
5858

5959
@Nested
60-
@DisplayName("vertifyAndConvertToJsonNode")
60+
//vertifyAndConvertToJsonNode
6161
class VerifyAndConvertToJsonNode {
6262

6363
private static final String ID_NAME = "destinationDefinitionId";
6464

6565
private final ObjectMapper mapper = MoreMappers.initMapper();
6666

6767
@Test
68-
@DisplayName("should correctly read yaml file")
68+
//should correctly read yaml file
6969
void correctlyReadTest() throws JsonProcessingException {
7070
final var jsonDefs = YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, GOOD_DES_DEF_YAML);
7171
final var defList = mapper.treeToValue(jsonDefs, StandardDestinationDefinition[].class);
@@ -74,37 +74,37 @@ void correctlyReadTest() throws JsonProcessingException {
7474
}
7575

7676
@Test
77-
@DisplayName("should error out on duplicate id")
77+
//should error out on duplicate id
7878
void duplicateIdTest() {
7979
assertThrows(RuntimeException.class, () -> YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, DUPLICATE_ID));
8080
}
8181

8282
@Test
83-
@DisplayName("should error out on duplicate name")
83+
//should error out on duplicate name
8484
void duplicateNameTest() {
8585
assertThrows(RuntimeException.class, () -> YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, DUPLICATE_NAME));
8686
}
8787

8888
@Test
89-
@DisplayName("should error out on empty file")
89+
//should error out on empty file
9090
void emptyFileTest() {
9191
assertThrows(RuntimeException.class, () -> YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, ""));
9292
}
9393

9494
@Test
95-
@DisplayName("should error out on bad data")
95+
//should error out on bad data
9696
void badDataTest() {
9797
assertThrows(RuntimeException.class, () -> YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, BAD_DATA));
9898
}
9999

100100
}
101101

102102
@Nested
103-
@DisplayName("verifyAndConvertToModelList")
103+
//verifyAndConvertToModelList
104104
class VerifyAndConvertToModelList {
105105

106106
@Test
107-
@DisplayName("should correctly read yaml file")
107+
//should correctly read yaml file
108108
void correctlyReadTest() {
109109
final var defs = YamlListToStandardDefinitions
110110
.verifyAndConvertToModelList(StandardDestinationDefinition.class, GOOD_DES_DEF_YAML);
@@ -113,28 +113,28 @@ void correctlyReadTest() {
113113
}
114114

115115
@Test
116-
@DisplayName("should error out on duplicate id")
116+
//should error out on duplicate id
117117
void duplicateIdTest() {
118118
assertThrows(RuntimeException.class,
119119
() -> YamlListToStandardDefinitions.verifyAndConvertToModelList(StandardDestinationDefinition.class, DUPLICATE_ID));
120120
}
121121

122122
@Test
123-
@DisplayName("should error out on duplicate name")
123+
//should error out on duplicate name
124124
void duplicateNameTest() {
125125
assertThrows(RuntimeException.class,
126126
() -> YamlListToStandardDefinitions.verifyAndConvertToModelList(StandardDestinationDefinition.class, DUPLICATE_NAME));
127127
}
128128

129129
@Test
130-
@DisplayName("should error out on empty file")
130+
//should error out on empty file
131131
void emptyFileTest() {
132132
assertThrows(RuntimeException.class,
133133
() -> YamlListToStandardDefinitions.verifyAndConvertToModelList(StandardDestinationDefinition.class, ""));
134134
}
135135

136136
@Test
137-
@DisplayName("should error out on bad data")
137+
//should error out on bad data
138138
void badDataTest() {
139139
assertThrows(RuntimeException.class,
140140
() -> YamlListToStandardDefinitions.verifyAndConvertToModelList(StandardDestinationDefinition.class, BAD_DATA));

‎airbyte-cdk/java/airbyte-cdk/dependencies/src/test/java/io/airbyte/workers/TestHarnessUtilsTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ private void runShutdown() {
6565
}
6666

6767
@SuppressWarnings("BusyWait")
68-
@DisplayName("Verify that shutdown waits indefinitely when heartbeat and process are healthy.")
68+
//Verify that shutdown waits indefinitely when heartbeat and process are healthy.
6969
@Test
7070
void testStartsWait() throws InterruptedException {
7171
when(process.isAlive()).thenReturn(true);
@@ -86,7 +86,7 @@ void testStartsWait() throws InterruptedException {
8686
}
8787

8888
@Test
89-
@DisplayName("Test heartbeat ends and graceful shutdown.")
89+
//Test heartbeat ends and graceful shutdown.
9090
void testGracefulShutdown() {
9191
when(heartbeatMonitor.isBeating()).thenReturn(false);
9292
when(process.isAlive()).thenReturn(false);
@@ -97,7 +97,7 @@ void testGracefulShutdown() {
9797
}
9898

9999
@Test
100-
@DisplayName("Test heartbeat ends and shutdown is forced.")
100+
//Test heartbeat ends and shutdown is forced.
101101
void testForcedShutdown() {
102102
when(heartbeatMonitor.isBeating()).thenReturn(false);
103103
when(process.isAlive()).thenReturn(true);
@@ -108,7 +108,7 @@ void testForcedShutdown() {
108108
}
109109

110110
@Test
111-
@DisplayName("Test process dies.")
111+
//Test process dies.
112112
void testProcessDies() {
113113
when(heartbeatMonitor.isBeating()).thenReturn(true);
114114
when(process.isAlive()).thenReturn(false);

‎airbyte-cdk/java/airbyte-cdk/gcs-destinations/src/test/java/io/airbyte/cdk/integrations/destination/gcs/csv/GcsCsvFormatConfigTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
import org.junit.jupiter.api.DisplayName;
2222
import org.junit.jupiter.api.Test;
2323

24-
@DisplayName("GcsCsvFormatConfig")
24+
//GcsCsvFormatConfig
2525
public class GcsCsvFormatConfigTest {
2626

2727
@Test
28-
@DisplayName("Flattening enums can be created from value string")
28+
//Flattening enums can be created from value string
2929
public void testFlatteningCreationFromString() {
3030
assertEquals(Flattening.NO, Flattening.fromValue("no flattening"));
3131
assertEquals(Flattening.ROOT_LEVEL, Flattening.fromValue("root level flattening"));

‎airbyte-cdk/java/airbyte-cdk/gcs-destinations/src/test/java/io/airbyte/cdk/integrations/destination/gcs/jsonl/GcsJsonlFormatConfigTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import org.junit.jupiter.api.DisplayName;
2020
import org.junit.jupiter.api.Test;
2121

22-
@DisplayName("GcsJsonlFormatConfig")
22+
//GcsJsonlFormatConfig
2323
public class GcsJsonlFormatConfigTest {
2424

2525
@Test

‎airbyte-cdk/java/airbyte-cdk/s3-destinations/src/test/java/io/airbyte/cdk/integrations/destination/s3/S3FormatConfigsTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
import org.junit.jupiter.api.DisplayName;
1717
import org.junit.jupiter.api.Test;
1818

19-
@DisplayName("S3FormatConfigs")
19+
//S3FormatConfigs
2020
public class S3FormatConfigsTest {
2121

2222
@Test
23-
@DisplayName("When CSV format is specified, it returns CSV format config")
23+
//When CSV format is specified, it returns CSV format config
2424
public void testGetCsvS3FormatConfig() {
2525
final JsonNode configJson = Jsons.jsonNode(Map.of(
2626
"format", Jsons.jsonNode(Map.of(

‎airbyte-cdk/java/airbyte-cdk/s3-destinations/src/test/java/io/airbyte/cdk/integrations/destination/s3/csv/S3CsvFormatConfigTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
import org.junit.jupiter.api.DisplayName;
2424
import org.junit.jupiter.api.Test;
2525

26-
@DisplayName("S3CsvFormatConfig")
26+
//S3CsvFormatConfig
2727
public class S3CsvFormatConfigTest {
2828

2929
@Test
30-
@DisplayName("Flattening enums can be created from value string")
30+
//Flattening enums can be created from value string
3131
public void testFlatteningCreationFromString() {
3232
assertEquals(Flattening.NO, Flattening.fromValue("no flattening"));
3333
assertEquals(Flattening.ROOT_LEVEL, Flattening.fromValue("root level flattening"));

‎airbyte-cdk/java/airbyte-cdk/s3-destinations/src/test/java/io/airbyte/cdk/integrations/destination/s3/jsonl/S3JsonlFormatConfigTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
import org.junit.jupiter.api.DisplayName;
2222
import org.junit.jupiter.api.Test;
2323

24-
@DisplayName("S3JsonlFormatConfig")
24+
//S3JsonlFormatConfig
2525
public class S3JsonlFormatConfigTest {
2626

2727
@Test
28-
@DisplayName("Flattening enums can be created from value string")
28+
//Flattening enums can be created from value string
2929
public void testFlatteningCreationFromString() {
3030
assertEquals(Flattening.NO, Flattening.fromValue("no flattening"));
3131
assertEquals(Flattening.ROOT_LEVEL, Flattening.fromValue("root level flattening"));

‎airbyte-cdk/java/airbyte-cdk/s3-destinations/src/test/java/io/airbyte/cdk/integrations/destination/s3/tamplate/S3FilenameTemplateManagerTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class S3FilenameTemplateManagerTest {
2626
private final S3FilenameTemplateManager s3FilenameTemplateManager = new S3FilenameTemplateManager();
2727

2828
@Test
29-
@DisplayName("Should replace the date placeholder with the current date in the format YYYY-MM-DD")
29+
//Should replace the date placeholder with the current date in the format YYYY-MM-DD
3030
void testDatePlaceholder()
3131
throws IOException {
3232
final String fileNamePattern = "test-{date}";
@@ -51,7 +51,7 @@ void testDatePlaceholder()
5151
}
5252

5353
@Test
54-
@DisplayName("Should replace the timestamp placeholder with the current timestamp in milliseconds")
54+
//Should replace the timestamp placeholder with the current timestamp in milliseconds
5555
void testTimestampPlaceholder()
5656
throws IOException {
5757
final String fileNamePattern = "test-{timestamp}.csv";
@@ -74,7 +74,7 @@ void testTimestampPlaceholder()
7474
}
7575

7676
@Test
77-
@DisplayName("Should sanitize the string and adapt it to applicable S3 format")
77+
//Should sanitize the string and adapt it to applicable S3 format
7878
void testIfFilenameTemplateStringWasSanitized() throws IOException {
7979
final String fileNamePattern = " te st.csv ";
8080
final String actual = s3FilenameTemplateManager

‎airbyte-cdk/java/airbyte-cdk/s3-destinations/src/test/java/io/airbyte/cdk/integrations/destination/s3/util/S3OutputPathHelperTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
class S3OutputPathHelperTest {
1616

1717
@Test
18-
@DisplayName("getOutputPrefix")
18+
//getOutputPrefix
1919
public void testGetOutputPrefix() {
2020
// No namespace
2121
assertEquals("bucket_path/stream_name", S3OutputPathHelper

0 commit comments

Comments
 (0)