Skip to content

Commit 1bcd36f

Browse files
change link file name
1 parent 23c2512 commit 1bcd36f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/templates/test_report.html.j2

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ function copyToClipBoard(htmlElement) {
171171
<h3>Artifacts</h3>
172172
<ul>
173173
{% for artifact in step_result_to_artifact_links[step_result.step.title] %}
174-
<li><a href="{{ artifact.url }}" download="{{ artifact.name }}">{{ artifact.name }}</a></li>
174+
<li><a href="{{ artifact.url }}" download>{{ artifact.name }}</a></li>
175175
{% endfor %}
176176
</ul>
177177
{% endif %}

airbyte-ci/connectors/pipelines/pipelines/models/artifacts.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ async def save_to_local_path(self, path: Path) -> Path:
2929
raise Exception(f"Failed to save artifact {self.name} to local path {path}")
3030

3131
async def upload_to_gcs(self, dagger_client: dagger.Client, bucket: str, key: str, gcs_credentials: dagger.Secret) -> str:
32-
gcs_cp_flags = [f"--content-disposition=attachment;filename='{self.name}'"]
32+
gcs_cp_flags = [f'--content-disposition=filename="{self.name}"']
3333
if self.content_type is not None:
3434
gcs_cp_flags = gcs_cp_flags + [f"--content-type={self.content_type}"]
3535

0 commit comments

Comments
 (0)