Skip to content

Commit e074811

Browse files
committed
add timezone to csv file
1 parent c28675f commit e074811

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

airbyte-cdk/java/airbyte-cdk/s3-destinations/src/main/java/io/airbyte/cdk/integrations/destination/s3/csv/StagingDatabaseCsvSheetGenerator.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import io.airbyte.cdk.integrations.base.JavaBaseConstants;
99
import io.airbyte.commons.json.Jsons;
1010
import io.airbyte.protocol.models.v0.AirbyteRecordMessage;
11-
import java.sql.Timestamp;
1211
import java.time.Instant;
1312
import java.util.Collections;
1413
import java.util.LinkedList;
@@ -62,14 +61,14 @@ public List<Object> getDataRow(final UUID id, final String formattedString, fina
6261
if (useDestinationsV2Columns) {
6362
return List.of(
6463
id,
65-
Timestamp.from(Instant.ofEpochMilli(emittedAt)),
64+
Instant.ofEpochMilli(emittedAt),
6665
"",
6766
formattedString);
6867
} else {
6968
return List.of(
7069
id,
7170
formattedString,
72-
Timestamp.from(Instant.ofEpochMilli(emittedAt)));
71+
Instant.ofEpochMilli(emittedAt));
7372
}
7473
}
7574

airbyte-cdk/java/airbyte-cdk/s3-destinations/src/test/java/io/airbyte/cdk/integrations/destination/s3/csv/S3CsvWriterTest.java

+4-7
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,10 @@ public void writesContentsCorrectly_when_stagingDatabaseConfig() throws IOExcept
284284
// carriage returns are required b/c RFC4180 requires it :(
285285
// Dynamically generate the timestamp because we generate in local time.
286286
assertEquals(
287-
String.format(
288-
"""
289-
f6767f7d-ce1e-45cc-92db-2ad3dfdd088e,"{""foo"":73}",%s\r
290-
2b95a13f-d54f-4370-a712-1c7bf2716190,"{""bar"":84}",%s\r
291-
""",
292-
Timestamp.from(Instant.ofEpochMilli(1234)),
293-
Timestamp.from(Instant.ofEpochMilli(2345))),
287+
"""
288+
f6767f7d-ce1e-45cc-92db-2ad3dfdd088e,"{""foo"":73}",1970-01-01T00:00:01.234Z\r
289+
2b95a13f-d54f-4370-a712-1c7bf2716190,"{""bar"":84}",1970-01-01T00:00:02.345Z\r
290+
""",
294291
outputStreams.get(0).toString(StandardCharsets.UTF_8));
295292
}
296293

0 commit comments

Comments
 (0)