Skip to content

Commit e6dcf00

Browse files
cdk-java: improve java compatibility for s3-glue (#47216)
a customer is trying to modify destination-s3-glue, which is written in java. It calls a constructor to BaseS3Destination that doesn't have all optional parameters, and defines a class that extends WriteConfig. I just added an @JvmOverload and a open to the respective lines
1 parent 9947b32 commit e6dcf00

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

airbyte-cdk/java/airbyte-cdk/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ corresponds to that version.
174174

175175
| Version | Date | Pull Request | Subject |
176176
|:-----------|:-----------|:------------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------|
177+
| 0.47.2 | 2024-10-21 | [\#47216](https://github.com/airbytehq/airbyte/pull/47216) | improve java compatibiilty|
177178
| 0.47.1 | 2024-09-27 | [\#45397](https://github.com/airbytehq/airbyte/pull/45397) | Allow logical replication from Postgres 16 read-replicas|
178179
| 0.47.0 | 2024-09-26 | [\#42030](https://github.com/airbytehq/airbyte/pull/42030) | minor refactor |
179180
| 0.46.1 | 2024-09-20 | [\#45700](https://github.com/airbytehq/airbyte/pull/45700) | Destinations: Fix bug in parsing jsonschema |
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version=0.47.1
1+
version=0.47.2

airbyte-cdk/java/airbyte-cdk/s3-destinations/src/main/kotlin/io/airbyte/cdk/integrations/destination/s3/BaseS3Destination.kt

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import java.util.function.Consumer
1919
private val LOGGER = KotlinLogging.logger {}
2020

2121
abstract class BaseS3Destination
22+
@JvmOverloads
2223
protected constructor(
2324
protected val configFactory: S3DestinationConfigFactory = S3DestinationConfigFactory(),
2425
protected val environment: Map<String, String> = System.getenv(),

airbyte-cdk/java/airbyte-cdk/s3-destinations/src/main/kotlin/io/airbyte/cdk/integrations/destination/s3/WriteConfig.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package io.airbyte.cdk.integrations.destination.s3
66

77
import io.airbyte.protocol.models.v0.DestinationSyncMode
88

9-
class WriteConfig
9+
open class WriteConfig
1010
@JvmOverloads
1111
constructor(
1212
val namespace: String?,

0 commit comments

Comments
 (0)