Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Hubspot: add conversionId to form submissions schema #55245

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kyleromines
Copy link
Contributor

@kyleromines kyleromines commented Mar 7, 2025

What

Add conversionId to the forms submission schema. You can see this is included here: https://developers.hubspot.com/docs/reference/api/marketing/forms/v1#get-submissions-for-a-form. For us this ID is unique across form submissions so I gave it the description that it is the unique ID for the table.

How

Added json to schema json

Review guide

  1. form_submissions.json

User Impact

Hubspot connector users will now get all fields association with form submissions

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@kyleromines kyleromines requested a review from a team as a code owner March 7, 2025 01:29
Copy link

vercel bot commented Mar 7, 2025

@kyleromines is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Mar 7, 2025
@kyleromines kyleromines changed the title add conversionId ✨ Source Hubspot: add conversionId to form submissions schema Mar 7, 2025
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 7, 2025
@kyleromines kyleromines temporarily deployed to community-ci-auto March 7, 2025 01:33 — with GitHub Actions Inactive
@natikgadzhi
Copy link
Contributor

@marcosmarxm can you give this a round of reviews please?

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 2:24pm

@kyleromines
Copy link
Contributor Author

@marcosmarxm can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/hubspot
Projects
Status: Ready to Ship
Development

Successfully merging this pull request may close these issues.

4 participants