(Do Not Merge) Source-Google-Ads: GAQL TypeError on Check #55804
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Debugging this: https://github.com/airbytehq/oncall/issues/7310 via Dev Image.
How
Getting this error on check:
Traceback (most recent call last):
File "/airbyte/integration_code/main.py", line 8, in
run()
File "/airbyte/integration_code/source_google_ads/run.py", line 16, in run
launch(source, sys.argv[1:])
File "/usr/local/lib/python3.10/site-packages/airbyte_cdk/entrypoint.py", line 263, in launch
for message in source_entrypoint.run(parsed_args):
File "/usr/local/lib/python3.10/site-packages/airbyte_cdk/entrypoint.py", line 126, in run
yield from map(AirbyteEntrypoint.airbyte_message_to_string, self.check(source_spec, config))
File "/usr/local/lib/python3.10/site-packages/airbyte_cdk/entrypoint.py", line 155, in check
check_result = self.source.check(self.logger, config)
File "/usr/local/lib/python3.10/site-packages/airbyte_cdk/sources/abstract_source.py", line 81, in check
check_succeeded, error = self.check_connection(logger, config)
File "/airbyte/integration_code/source_google_ads/source.py", line 185, in check_connection
table_name = query["table_name"]
TypeError: 'GAQL' object is not subscriptable
I suspect something is off with their config, but it is hard to check since this is during source creation. Will ask the user to see if they can also provide more details.
Also, not sure if we need to parse the table_name as well here?
I think once we have these debug logs we should be able to know for sure.
Review guide
User Impact
Can this PR be safely reverted and rolled back?