docs: fix technical inaccuracies in Local JSON destination documentation #55808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
🤖 Devin AI EngineerOriginal prompt from [email protected]: I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ian-at-airbyte
added
area/documentation
airbyte-integrations/connectors/destination-local-json/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
…lumes first Co-Authored-By: [email protected] <[email protected]>
| 3. **Access Data After Sync Completion** | ||
| - For completed pods where the data is stored in the persistent volume: | ||
| ``` | ||
| kubectl --kubeconfig ~/.airbyte/abctl/abctl.kubeconfig --namespace airbyte-abctl run file-access --image=busybox --restart=Never -it --rm --volumes=local-json-data:/data -- /bin/sh -c "ls -la /data" |
There was a problem hiding this comment.
This part is incorrect. kubectl run does not support --volumes directly. You need to define a volume using a pod or deployment spec instead.
| ``` | ||
| - To view file contents directly: | ||
| ``` | ||
| kubectl --kubeconfig ~/.airbyte/abctl/abctl.kubeconfig --namespace airbyte-abctl exec -it file-access -- cat /data/your_stream_name/*.jsonl |
There was a problem hiding this comment.
What's the expected location of this file? My terminal tells me no matches are found.
| - In the Airbyte UI, create or edit your connection to use this destination | ||
| - **Important**: You must configure the destination pod to mount the PVC during sync: | ||
| ``` | ||
| kubectl --kubeconfig ~/.airbyte/abctl/abctl.kubeconfig --namespace airbyte-abctl patch deployment airbyte-abctl-destination -p '{"spec":{"template":{"spec":{"volumes":[{"name":"data-volume","persistentVolumeClaim":{"claimName":"local-json-data"}}],"containers":[{"name":"airbyte-abctl-destination","volumeMounts":[{"name":"data-volume","mountPath":"/local"}]}]}}}}' |
There was a problem hiding this comment.
Please check this. I get: Error from server (NotFound): deployments.apps "airbyte-abctl-destination" not found
…N destination Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes technical inaccuracies in the Local JSON destination documentation, particularly regarding the default data write location and the LOCAL_ROOT environment variable. It updates the documentation to reflect Airbyte's current deployment architecture using abctl instead of docker-compose.
Link to Devin run: https://app.devin.ai/sessions/69d164d256f8438f80b5c11a52242fcf
Requested by: [email protected]