Skip to content

Commit 8218423

Browse files
authored
Add missing setter in builder classes (#3174)
This adds setters to `@PluginBuilderAttribute` fields in setter classes that lack the corresponding public setter.
1 parent 20035c4 commit 8218423

File tree

7 files changed

+49
-6
lines changed

7 files changed

+49
-6
lines changed

log4j-1.2-api/src/main/java/org/apache/log4j/builders/filter/StringMatchFilterBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ private Filter createFilter(final String text, final boolean acceptOnMatch) {
8686
? org.apache.logging.log4j.core.Filter.Result.ACCEPT
8787
: org.apache.logging.log4j.core.Filter.Result.DENY;
8888
return FilterWrapper.adapt(StringMatchFilter.newBuilder()
89-
.setMatchString(text)
89+
.setText(text)
9090
.setOnMatch(onMatch)
9191
.setOnMismatch(org.apache.logging.log4j.core.Filter.Result.NEUTRAL)
9292
.build());

log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/StringMatchFilterTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public void testFilterBuilderFailsWithNullText() {
4747
@Test
4848
void testFilterBuilderFailsWithExceptionOnNullText() {
4949
Assertions.assertThrows(IllegalArgumentException.class, () -> StringMatchFilter.newBuilder()
50-
.setMatchString(null));
50+
.setText(null));
5151
}
5252

5353
/**
@@ -56,7 +56,7 @@ void testFilterBuilderFailsWithExceptionOnNullText() {
5656
@Test
5757
void testFilterBuilderFailsWithExceptionOnEmptyText() {
5858
Assertions.assertThrows(IllegalArgumentException.class, () -> StringMatchFilter.newBuilder()
59-
.setMatchString(""));
59+
.setText(""));
6060
}
6161

6262
/**

log4j-core/src/main/java/org/apache/logging/log4j/core/filter/StringMatchFilter.java

+12-1
Original file line numberDiff line numberDiff line change
@@ -242,12 +242,23 @@ public static class Builder extends AbstractFilterBuilder<StringMatchFilter.Buil
242242
@Required(message = "No text provided for StringMatchFilter")
243243
private String text;
244244

245+
/**
246+
* @deprecated since 2.25.0, use {@link #setText} instead.
247+
*/
248+
@Deprecated
249+
public StringMatchFilter.Builder setMatchString(final String text) {
250+
this.text = Assert.requireNonEmpty(text, "The 'text' argument must not be null or empty.");
251+
return this;
252+
}
253+
245254
/**
246255
* Sets the text to search in event messages.
256+
*
247257
* @param text the text to search in event messages.
248258
* @return this instance.
259+
* @since 2.25.0
249260
*/
250-
public StringMatchFilter.Builder setMatchString(final String text) {
261+
public StringMatchFilter.Builder setText(final String text) {
251262
this.text = Assert.requireNonEmpty(text, "The 'text' argument must not be null or empty.");
252263
return this;
253264
}

log4j-core/src/main/java/org/apache/logging/log4j/core/filter/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* {@link org.apache.logging.log4j.core.Filter#ELEMENT_TYPE filter}.
2323
*/
2424
@Export
25-
@Version("2.21.1")
25+
@Version("2.25.0")
2626
package org.apache.logging.log4j.core.filter;
2727

2828
import org.osgi.annotation.bundle.Export;

log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java

+24
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,30 @@ public B setMapPrefix(final String prefix) {
454454
}
455455
return asBuilder();
456456
}
457+
458+
/**
459+
* @since 2.25.0
460+
*/
461+
public B setThreadContextIncludes(String threadContextIncludes) {
462+
this.threadContextIncludes = threadContextIncludes;
463+
return asBuilder();
464+
}
465+
466+
/**
467+
* @since 2.25.0
468+
*/
469+
public B setThreadContextExcludes(String threadContextExcludes) {
470+
this.threadContextExcludes = threadContextExcludes;
471+
return asBuilder();
472+
}
473+
474+
/**
475+
* @since 2.25.0
476+
*/
477+
public B setOmitEmptyFields(boolean omitEmptyFields) {
478+
this.omitEmptyFields = omitEmptyFields;
479+
return asBuilder();
480+
}
457481
}
458482

459483
/**

log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java

+8
Original file line numberDiff line numberDiff line change
@@ -850,6 +850,14 @@ public Rfc5424LayoutBuilder setLoggerFields(final LoggerFields[] loggerFields) {
850850
return this;
851851
}
852852

853+
/**
854+
* @since 2.25.0
855+
*/
856+
public Rfc5424LayoutBuilder setEnterpriseNumber(Integer enterpriseNumber) {
857+
this.enterpriseNumber = enterpriseNumber;
858+
return this;
859+
}
860+
853861
@Override
854862
public Rfc5424Layout build() {
855863
if (includes != null && excludes != null) {

log4j-core/src/main/java/org/apache/logging/log4j/core/layout/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* {@link org.apache.logging.log4j.core.Layout#ELEMENT_TYPE layout}.
2323
*/
2424
@Export
25-
@Version("2.24.0")
25+
@Version("2.25.0")
2626
package org.apache.logging.log4j.core.layout;
2727

2828
import org.osgi.annotation.bundle.Export;

0 commit comments

Comments
 (0)