Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve on extensibility of BuiltConfiguration/DefaultConfigurationBuilder
ConfigurationBuilder interface:
DefaultConfigurationBuilder
public ConfigurationBuilder<T> addProperty(PropertyComponentBuilder)
protected Optional<String> getRootProperty(String)
protected Optional<Component> getComponent(String)
protected Component getOrCreateComponent(String)
protected Component getRootComponent()
rootComponent
nowBuiltConfiguration:
org.apache.logging.log4j.core.config.builder.api
org.apache.logging.log4j.core.config.builder.impl
org.apache.logging.log4j.core.config.properties
Configurator1Test
where the test configuration was being inittialized twiceNOTE to reviewers - please review carefully due to API changes and specifically:
rootComponent
in DefaultConfigurationBuilderDefaultConfigurationBuilder#build
to theBuiltConfiguration
constructor