Add collectionName and databaseName attributes to MongoDbProvider

[jesmith17]

Ports #3322 to 2.x

[jesmith17]

@vy I went ahead and did a new PR to merge with 2.x branch because the classes, projects, and packages already had changes in the 3.x stuff that did seem to make sense to back-port. So tried to just back-port the specific code for this change and leave the rest alone.

[vy]

Thanks Josh. I was about to suggest you creating separate PRs for 2.x and main, but you were already ahead of me. 💯 I will review this one on Monday. Op za 15 feb 2025 om 06:22 schreef Josh Smith ***@***.***>

…

@vy <https://github.com/vy> I went ahead and did a new PR to merge with 2.x branch because the classes, projects, and packages already had changes in the 3.x stuff that did seem to make sense to back-port. So tried to just back-port the specific code for this change and leave the rest alone. — Reply to this email directly, view it on GitHub <#3467 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAARTSJCAMTPONE3IN4IOIT2P3FLFAVCNFSM6AAAAABXF6KYPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQG42DSMJUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: jesmith17]*jesmith17* left a comment (apache/logging-log4j2#3467) <#3467 (comment)> @vy <https://github.com/vy> I went ahead and did a new PR to merge with 2.x branch because the classes, projects, and packages already had changes in the 3.x stuff that did seem to make sense to back-port. So tried to just back-port the specific code for this change and leave the rest alone. — Reply to this email directly, view it on GitHub <#3467 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAARTSJCAMTPONE3IN4IOIT2P3FLFAVCNFSM6AAAAABXF6KYPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQG42DSMJUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[github-actions]

Job	Requested goals	Build Tool Version	Build Outcome	Build Scan®
build-macos-latest	clean install	3.9.8	✅
build-ubuntu-latest	clean install	3.9.8	✅
build-windows-latest	clean install	3.9.8	✅

Generated by gradle/develocity-actions

[vy]

@jesmith17, pushed some minor fixes and dropped some remarks. I'd appreciate it if you can address them.

[vy]

We use mvnw both locally and in CI over several platforms, including macOS. Could you make sure you have a clean checkout of the source repository and if it is still failing, share the output, please? Op di 18 feb 2025 om 14:45 schreef Josh Smith ***@***.***>

…

***@***.**** commented on this pull request. ------------------------------ In log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java <#3467 (comment)> : > @@ -67,21 +67,23 @@ public MongoDb4Connection( final ConnectionString connectionString, final MongoClient mongoClient, final MongoDatabase mongoDatabase, + final String collectionName, So the first problem is that the maven-wrapper breaks when running it on my machine using maven 3.9.9 Specifically it complains about needing to update the distributionSha256Sum which is impossible because 3.9.9. comes with a sha-512 sum. In order to get any of the ./mvnw commands to run I had to rebuild the wrapper, but I suspect you don't want me to check that in. Seems like there is an undocumented dependent on a specific version of maven that needs to be addressed. — Reply to this email directly, view it on GitHub <#3467 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAARTSLKCB7CV5OKYNPRZX32QM2PZAVCNFSM6AAAAABXF6KYPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRTGYZDIOBRHE> . You are receiving this because you were assigned.Message ID: ***@***.***>

[vy]

You’re right, we can and should indeed improve on this. Op di 18 feb 2025 om 14:24 schreef Josh Smith ***@***.***>

…

***@***.**** commented on this pull request. ------------------------------ In log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Provider.java <#3467 (comment)> : > + ConnectionString connectionString; + try { + connectionString = new ConnectionString(connectionStringSource); + } catch (final IllegalArgumentException e) { + LOGGER.error("Invalid MongoDB connection string `{}`.", connectionStringSource, e); + return null; + } + + String effectiveDatabaseName = databaseName != null ? databaseName : connectionString.getDatabase(); + String effectiveCollectionName = collectionName != null ? collectionName : connectionString.getCollection(); + // Validate the provided databaseName property + try { + MongoNamespace.checkDatabaseNameValidity(effectiveDatabaseName); + } catch (final IllegalArgumentException e) { + LOGGER.error("Invalid MongoDB database name `{}`.", effectiveDatabaseName, e); + return null; + } + // Validate the provided collectionName property + try { + MongoNamespace.checkCollectionNameValidity(effectiveCollectionName); + } catch (final IllegalArgumentException e) { + LOGGER.error("Invalid MongoDB collection name `{}`.", effectiveCollectionName, e); + return null; + } For people just trying to figure out how to add functionality its really hard when disputes about coding approach between maintainers are getting done inside the comments for a specific PR. I would recommend that this becomes something you document better to make this easier for others. — Reply to this email directly, view it on GitHub <#3467 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAARTSKCPLWIUKTK5FFEMZT2QMYBJAVCNFSM6AAAAABXF6KYPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRTGU2TSNJZGA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[jesmith17]

@vy Just did a new clone of the full repo, into a new directory. Verified that it's the 2.x branch. Running ./mvnw install -DskipTests produced the following errror.

oshsmith@Joshs-Macbook-Air-2024 log4j-temp % ./mvnw install -DskipTests
Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised.
If you updated your Maven version, you need to update the specified distributionSha256Sum property.
joshsmith@Joshs-Macbook-Air-2024 log4j-temp %

even trying to run a command like ./mvnw --version returns the same error.

In trying to see if I could manually view the sha256 for the 3.9.8 download, it appears to also only offer a sha512.

Here is the content of my maven-wrapper.properties file included with the checkout. Ommitting the comments at the top for brevity.

distributionSha256Sum=8351955a9acf2f83c136c4eee0f6db894ab6265fdbe0a94b32a380307dbaa3e1
distributionType=only-script
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.8/apache-maven-3.9.8-bin.zip
wrapperVersion=3.3.2
~

[ppkarwasz]

@vy Just did a new clone of the full repo, into a new directory. Verified that it's the 2.x branch. Running ./mvnw install -DskipTests produced the following errror.

oshsmith@Joshs-Macbook-Air-2024 log4j-temp % ./mvnw install -DskipTests
Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised.
If you updated your Maven version, you need to update the specified distributionSha256Sum property.
joshsmith@Joshs-Macbook-Air-2024 log4j-temp %

Try removing the ~/.m2/wrapper folder. It is just a cache. In main we did have a script Maven Wrapper shell script, in 2.x we have the more recent only-script version. Maybe they are incompatible.

[jesmith17]

@ppkarwasz
Removing the .mvn/wrapper folder all together just changes it to an error complaining that it can't find the maven-wrapper.properties.

./mvnw: line 114: ./.mvn/wrapper/maven-wrapper.properties: No such file or directory
cannot read distributionUrl property in ./.mvn/wrapper/maven-wrapper.properties
joshsmith@Joshs-Macbook-Air-2024 log4j-temp %

[ppkarwasz]

Removing the .mvn/wrapper folder all together just changes it to an error complaining that it can't find the maven-wrapper.properties.

By ~/.m2/wrapper folder I meant the .m2/wrapper subfolder of your home directory. The problematic data is there and this is why the problem persists, even if you make a clean Git checkout.

[jesmith17]

@ppkarwasz There is no ~/.m2/wrapper folder in my home mvn install. I just verified.

But even if that was the offending file then deleting the one in the code base wouldn't have trigger an error about the file missing as it would have found the file in my local home directory, correct?

[vy]

Thanks so much Josh for bearing with us to deliver this feature. There are some last mile wrinkles to be ironed out in the tests, I will take care of them. (Please keep the PR open, I will continue working on it.) Op wo 19 feb 2025 om 17:59 schreef Josh Smith ***@***.***>

…

***@***.**** commented on this pull request. ------------------------------ In log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java <#3467 (comment)> : > @@ -67,21 +67,23 @@ public MongoDb4Connection( final ConnectionString connectionString, final MongoClient mongoClient, final MongoDatabase mongoDatabase, + final String collectionName, Trying the VERBOSE command above produced this ***@***.*** log4j-temp % MVNW_VERBOSE=true ./mvnw validate -N Couldn't find MAVEN_HOME, downloading and installing it ... Downloading from: https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.8/apache-maven-3.9.8-bin.zip Downloading to: /var/folders/wm/96zyw_3x4cdbvycjl7btg8sc0000gn/T/tmp.4xLeCVRCI2/apache-maven-3.9.8-bin.zip Found curl ... using curl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 8979k 100 8979k 0 0 1584k 0 0:00:05 0:00:05 --:--:-- 1402k Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised. If you updated your Maven version, you need to update the specified distributionSha256Sum property. ***@***.*** log4j-temp % that's after doing a git reset to bring back the deleted maven-wrapper.properties file. I suspect that this needs to be moved to an issue so we can separate the resolution of this from the approval of the code changes for the appender. — Reply to this email directly, view it on GitHub <#3467 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAARTSMOWNLI4JFKYGYHUJ32QSZ7DAVCNFSM6AAAAABXF6KYPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRXGQ2DGMBRGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vy]

Couldn't merge due to missing signatures – squashed and committed in 07590bc.