Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log4j 3.x - StringMatchFilter - guard potential NPEs and builder validation/API #3509

Open
JWT007 opened this issue Mar 2, 2025 · 0 comments · May be fixed by #3510
Open

Log4j 3.x - StringMatchFilter - guard potential NPEs and builder validation/API #3509

JWT007 opened this issue Mar 2, 2025 · 0 comments · May be fixed by #3510
Assignees
@JWT007
Labels
bug Incorrect, unexpected, or unintended behavior of existing code configuration Affects the configuration system in a general way java Pull requests that update Java code

Comments

@JWT007
Copy link
Contributor

JWT007 commented Mar 2, 2025

This is a parallel of Ticket #3153 for the main (3.x) branch.

StringMatchFilter:

  • add validation on 'text' attribute to class constructor and builder (non-blank)
  • add JVerify nullability annotations to class
  • replace 'setMatchString' builder method with 'setText'
  • add javadoc details about the specific StringMatchFilter implementation/behaviour
  • update tests
@JWT007 JWT007 self-assigned this Mar 2, 2025
This was referenced Mar 2, 2025
Open
Closed
@JWT007 JWT007 added bug Incorrect, unexpected, or unintended behavior of existing code java Pull requests that update Java code configuration Affects the configuration system in a general way labels Mar 2, 2025
@JWT007 JWT007 linked a pull request Mar 2, 2025 that will close this issue
Update StringMatchFilter builder API (#3509) #3510
Open
JWT007 added a commit to JWT007/logging-log4j2 that referenced this issue Mar 2, 2025
@JWT007
Minor fixes to StringMatchFilter (apache#3509)
7add1f6
JWT007 added a commit to JWT007/logging-log4j2 that referenced this issue Mar 2, 2025
@JWT007
Minor javadoc correction. (apache#3509)
dd1ff85
JWT007 added a commit to JWT007/logging-log4j2 that referenced this issue Mar 2, 2025
@JWT007
Spotless fix. (apache#3509)
18449f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JWT007 JWT007

Labels
bug Incorrect, unexpected, or unintended behavior of existing code configuration Affects the configuration system in a general way java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update StringMatchFilter builder API (#3509) JWT007/logging-log4j2
1 participant
@JWT007