fix: cronOperator/serverResubmitWf retry create workflow on transient error. Fixes argoproj#13970 (argoproj#13971)

tczhao · tczhao · commit bf81a0558528 · 2024-12-06T03:37:32.000Z
Signed-off-by: Tianchu Zhao &lt;evantczhao@gmail.com&gt;
diff --git a/workflow/util/util.go b/workflow/util/util.go
@@ -193,7 +193,13 @@ func SubmitWorkflow(ctx context.Context, wfIf v1alpha1.WorkflowInterface, wfClie
 		}
 		return wf, err
 	} else {
-		return wfIf.Create(ctx, wf, metav1.CreateOptions{})
+		var runWf *wfv1.Workflow
+		err = waitutil.Backoff(retry.DefaultRetry, func() (bool, error) {
+			var err error
+			runWf, err = wfIf.Create(ctx, wf, metav1.CreateOptions{})
+			return !errorsutil.IsTransientErr(err), err
+		})
+		return runWf, err
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,13 @@ func SubmitWorkflow(ctx context.Context, wfIf v1alpha1.WorkflowInterface, wfClie`
`193`	`193`	`}`
`194`	`194`	`return wf, err`
`195`	`195`	`} else {`
`196`		`- return wfIf.Create(ctx, wf, metav1.CreateOptions{})`
	`196`	`+ var runWf *wfv1.Workflow`
	`197`	`+ err = waitutil.Backoff(retry.DefaultRetry, func() (bool, error) {`
	`198`	`+ var err error`
	`199`	`+ runWf, err = wfIf.Create(ctx, wf, metav1.CreateOptions{})`
	`200`	`+ return !errorsutil.IsTransientErr(err), err`
	`201`	`+ })`
	`202`	`+ return runWf, err`
`197`	`203`	`}`
`198`	`204`	`}`
`199`	`205`