Skip to content

Commit c4516f4

Browse files
authoredMar 31, 2022
Remove hardcoded version in Makefile (#317)
Description of changes: Removes the hardcoded version number in the `Makefile`, replacing it with a shell script that pulls the latest git tag (or dirty if not on a direct tag) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 8a55c53 commit c4516f4

File tree

3 files changed

+1
-58
lines changed

3 files changed

+1
-58
lines changed
 

‎.github/workflows/version-check.yaml

-21
This file was deleted.

‎Makefile

+1-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ GO111MODULE=on
66
AWS_SERVICE=$(shell echo $(SERVICE) | tr '[:upper:]' '[:lower:]')
77

88
# Build ldflags
9-
VERSION ?= "v0.18.1"
9+
VERSION ?= $(shell git describe --tags --always --dirty)
1010
GITCOMMIT=$(shell git rev-parse HEAD)
1111
BUILDDATE=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
1212
IMPORT_PATH=github.com/aws-controllers-k8s/code-generator
@@ -52,9 +52,6 @@ local-build-controller-image: export LOCAL_MODULES = true
5252
local-build-controller-image: ## Build container image for SERVICE allowing local modules
5353
@./scripts/build-controller-image.sh $(AWS_SERVICE)
5454

55-
check-versions: ## Checks the code-generator version matches the runtime dependency version
56-
@./scripts/check-versions.sh $(VERSION)
57-
5855
test: ## Run code tests
5956
go test ${GO_CMD_FLAGS} ./...
6057

‎scripts/check-versions.sh

-33
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.