Prepare repository for tag conversion function signature update

The To/FromACKTags function signatures are changing with the next
code-gen release. This PR aims to ensure custom code adapts as well.

Author: michaelhtm

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,8 +1,8 @@
 ack_generate_info:
-  build_date: "2025-02-20T18:23:50Z"
-  build_hash: a326346bd3a6973254d247c9ab2dc76790c36241
+  build_date: "2025-03-13T21:31:30Z"
+  build_hash: e173c488067c368725a671a9e7ced476d6134219
   go_version: go1.24.0
-  version: v0.43.2
+  version: v0.43.2-5-ge173c48
 api_directory_checksum: 73ba0942f1950c4700c2bff40dda380d5994ca6b
 api_version: v1alpha1
 aws_sdk_go_version: 1.32.6

pkg/resource/domain/hooks.go

@@ -63,12 +63,12 @@ func (rm *resourceManager) syncTags(
 
 	resourceArn := latest.ko.Status.ACKResourceMetadata.ARN
 
-	desiredTags := ToACKTags(desired.ko.Spec.Tags)
-	latestTags := ToACKTags(latest.ko.Spec.Tags)
+	desiredTags, _ := convertToOrderedACKTags(desired.ko.Spec.Tags)
+	latestTags, _ := convertToOrderedACKTags(latest.ko.Spec.Tags)
 
 	added, _, removed := ackcompare.GetTagsDifference(latestTags, desiredTags)
 
-	toAdd := FromACKTags(added)
+	toAdd := fromACKTags(added, nil)
 
 	var toDeleteTagKeys []string
 	for k, _ := range removed {
@@ -128,13 +128,13 @@ func compareTags(
 	if len(a.ko.Spec.Tags) != len(b.ko.Spec.Tags) {
 		delta.Add("Spec.Tags", a.ko.Spec.Tags, b.ko.Spec.Tags)
 	} else if len(a.ko.Spec.Tags) > 0 {
-		desiredTags := ToACKTags(a.ko.Spec.Tags)
-		latestTags := ToACKTags(b.ko.Spec.Tags)
+		desiredTags, _ := convertToOrderedACKTags(a.ko.Spec.Tags)
+		latestTags, _ := convertToOrderedACKTags(b.ko.Spec.Tags)
 
 		added, _, removed := ackcompare.GetTagsDifference(latestTags, desiredTags)
 
-		toAdd := FromACKTags(added)
-		toDelete := FromACKTags(removed)
+		toAdd := fromACKTags(added, nil)
+		toDelete := fromACKTags(removed, nil)
 
 		if len(toAdd) != 0 || len(toDelete) != 0 {
 			delta.Add("Spec.Tags", a.ko.Spec.Tags, b.ko.Spec.Tags)

pkg/resource/domain/manager.go

@@ -38,12 +38,12 @@ func (rm *resourceManager) syncTags(
 
 	resourceArn := latest.ko.Status.ACKResourceMetadata.ARN
 
-	desiredTags := ToACKTags(desired.ko.Spec.Tags)
-	latestTags := ToACKTags(latest.ko.Spec.Tags)
+	desiredTags, _ := convertToOrderedACKTags(desired.ko.Spec.Tags)
+	latestTags, _ := convertToOrderedACKTags(latest.ko.Spec.Tags)
 
 	added, _, removed := ackcompare.GetTagsDifference(latestTags, desiredTags)
 
-	toAdd := FromACKTags(added)
+	toAdd := fromACKTags(added, nil)
 
 	var toDeleteTagKeys []string
 	for k, _ := range removed {
@@ -103,13 +103,13 @@ func compareTags(
 	if len(a.ko.Spec.Tags) != len(b.ko.Spec.Tags) {
 		delta.Add("Spec.Tags", a.ko.Spec.Tags, b.ko.Spec.Tags)
 	} else if len(a.ko.Spec.Tags) > 0 {
-		desiredTags := ToACKTags(a.ko.Spec.Tags)
-		latestTags := ToACKTags(b.ko.Spec.Tags)
+		desiredTags, _ := convertToOrderedACKTags(a.ko.Spec.Tags)
+		latestTags, _ := convertToOrderedACKTags(b.ko.Spec.Tags)
 
 		added, _, removed := ackcompare.GetTagsDifference(latestTags, desiredTags)
 
-		toAdd := FromACKTags(added)
-		toDelete := FromACKTags(removed)
+		toAdd := fromACKTags(added, nil)
+		toDelete := fromACKTags(removed, nil)
 
 		if len(toAdd) != 0 || len(toDelete) != 0 {
 			delta.Add("Spec.Tags", a.ko.Spec.Tags, b.ko.Spec.Tags)