Skip to content

Commit a6e024d

Browse files
michaelhtmmichaelhtm
committed
Remove ChangeBatch from spec
With this change we will be removing the blocker that we had from going GA with this controller.
1 parent 486f26d commit a6e024d

10 files changed

+59
-490
lines changed

‎apis/v1alpha1/ack-generate-metadata.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2025-03-14T20:40:51Z"
2+
build_date: "2025-03-14T21:17:11Z"
33
build_hash: 0ab258c51775fd52af32e649da00d57373b20869
44
go_version: go1.24.0
55
version: v0.43.2-6-g0ab258c
6-
api_directory_checksum: b920521646bacef1fba9d0b97a423d11565c7a60
6+
api_directory_checksum: 72b15cdf04da5bbe0694a4a7d2987838696709a5
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: cb391b9a34945fd5dd28af68abd902a68d209e93
10+
file_checksum: 96f2535415c83b5c233f78afa95088a0288c634c
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

‎apis/v1alpha1/generator.yaml

+27-26
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ ignore:
44
- CreateHostedZoneInput.CallerReference
55
- CreateHealthCheckInput.CallerReference
66
- ResourceRecordSet.GeoProximityLocation
7+
- ChangeResourceRecordSetsInput.ChangeBatch
78
operations: null
89
resource_names:
910
- CidrCollection
@@ -54,27 +55,27 @@ resources:
5455
fields:
5556
AliasTarget:
5657
from:
57-
operation: ChangeResourceRecordSets
58-
path: ChangeBatch.Changes.ResourceRecordSet.AliasTarget
58+
operation: ListResourceRecordSets
59+
path: ResourceRecordSets.AliasTarget
5960
# This field cannot be ignored, but values for this will be overriden and should not be used
6061
ChangeBatch:
6162
is_required: false
6263
CidrRoutingConfig:
6364
from:
64-
operation: ChangeResourceRecordSets
65-
path: ChangeBatch.Changes.ResourceRecordSet.CidrRoutingConfig
65+
operation: ListResourceRecordSets
66+
path: ResourceRecordSets.CidrRoutingConfig
6667
Failover:
6768
from:
68-
operation: ChangeResourceRecordSets
69-
path: ChangeBatch.Changes.ResourceRecordSet.Failover
69+
operation: ListResourceRecordSets
70+
path: ResourceRecordSets.Failover
7071
GeoLocation:
7172
from:
72-
operation: ChangeResourceRecordSets
73-
path: ChangeBatch.Changes.ResourceRecordSet.GeoLocation
73+
operation: ListResourceRecordSets
74+
path: ResourceRecordSets.GeoLocation
7475
HealthCheckId:
7576
from:
76-
operation: ChangeResourceRecordSets
77-
path: ChangeBatch.Changes.ResourceRecordSet.HealthCheckId
77+
operation: ListResourceRecordSets
78+
path: ResourceRecordSets.HealthCheckId
7879
# Changing this value after a CR has been created could result in orphaned record sets
7980
HostedZoneId:
8081
references:
@@ -88,48 +89,48 @@ resources:
8889
ChangeResourceRecordSet request"
8990
MultiValueAnswer:
9091
from:
91-
operation: ChangeResourceRecordSets
92-
path: ChangeBatch.Changes.ResourceRecordSet.MultiValueAnswer
92+
operation: ListResourceRecordSets
93+
path: ResourceRecordSets.MultiValueAnswer
9394
# Changing this value after a CR has been created could result in orphaned record sets.
9495
# Note that the name refers to the subdomain value of a record set and not the fully
9596
# qualified DNS name
9697
Name:
9798
from:
98-
operation: ChangeResourceRecordSets
99-
path: ChangeBatch.Changes.ResourceRecordSet.Name
99+
operation: ListResourceRecordSets
100+
path: ResourceRecordSets.Name
100101
is_immutable: true
101102
# Changing this value after a CR has been created could result in orphaned record sets
102103
RecordType:
103104
from:
104-
operation: ChangeResourceRecordSets
105-
path: ChangeBatch.Changes.ResourceRecordSet.Type
105+
operation: ListResourceRecordSets
106+
path: ResourceRecordSets.Type
106107
is_required: true
107108
is_immutable: true
108109
Region:
109110
from:
110-
operation: ChangeResourceRecordSets
111-
path: ChangeBatch.Changes.ResourceRecordSet.Region
111+
operation: ListResourceRecordSets
112+
path: ResourceRecordSets.Region
112113
ResourceRecords:
113114
from:
114-
operation: ChangeResourceRecordSets
115-
path: ChangeBatch.Changes.ResourceRecordSet.ResourceRecords
115+
operation: ListResourceRecordSets
116+
path: ResourceRecordSets.ResourceRecords
116117
# Changing this value after a CR has been created could result in orphaned record sets
117118
SetIdentifier:
118119
from:
119-
operation: ChangeResourceRecordSets
120-
path: ChangeBatch.Changes.ResourceRecordSet.SetIdentifier
120+
operation: ListResourceRecordSets
121+
path: ResourceRecordSets.SetIdentifier
121122
is_immutable: true
122123
Status:
123124
print:
124125
name: STATUS
125126
TTL:
126127
from:
127-
operation: ChangeResourceRecordSets
128-
path: ChangeBatch.Changes.ResourceRecordSet.TTL
128+
operation: ListResourceRecordSets
129+
path: ResourceRecordSets.TTL
129130
Weight:
130131
from:
131-
operation: ChangeResourceRecordSets
132-
path: ChangeBatch.Changes.ResourceRecordSet.Weight
132+
operation: ListResourceRecordSets
133+
path: ResourceRecordSets.Weight
133134
hooks:
134135
sdk_create_post_build_request:
135136
template_path: hooks/record_set/sdk_create_post_build_request.go.tpl

‎apis/v1alpha1/record_set.go

+1-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎apis/v1alpha1/types.go

+1-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎apis/v1alpha1/zz_generated.deepcopy.go

-21
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎config/crd/bases/route53.services.k8s.aws_recordsets.yaml

-96
Original file line numberDiff line numberDiff line change
@@ -66,102 +66,6 @@ spec:
6666
hostedZoneID:
6767
type: string
6868
type: object
69-
changeBatch:
70-
description: A complex type that contains an optional comment and
71-
the Changes element.
72-
properties:
73-
changes:
74-
items:
75-
description: The information for each resource record set that
76-
you want to change.
77-
properties:
78-
action:
79-
type: string
80-
resourceRecordSet:
81-
description: Information about the resource record set to
82-
create or delete.
83-
properties:
84-
aliasTarget:
85-
description: |-
86-
Alias resource record sets only: Information about the Amazon Web Services
87-
resource, such as a CloudFront distribution or an Amazon S3 bucket, that
88-
you want to route traffic to.
89-
90-
When creating resource record sets for a private hosted zone, note the following:
91-
92-
* For information about creating failover resource record sets in a private
93-
hosted zone, see Configuring Failover in a Private Hosted Zone (https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/dns-failover-private-hosted-zones.html).
94-
properties:
95-
dnsName:
96-
type: string
97-
evaluateTargetHealth:
98-
type: boolean
99-
hostedZoneID:
100-
type: string
101-
type: object
102-
cidrRoutingConfig:
103-
description: |-
104-
The object that is specified in resource record set object when you are linking
105-
a resource record set to a CIDR location.
106-
107-
A LocationName with an asterisk “*” can be used to create a default CIDR
108-
record. CollectionId is still required for default record.
109-
properties:
110-
collectionID:
111-
type: string
112-
locationName:
113-
type: string
114-
type: object
115-
failover:
116-
type: string
117-
geoLocation:
118-
description: A complex type that contains information
119-
about a geographic location.
120-
properties:
121-
continentCode:
122-
type: string
123-
countryCode:
124-
type: string
125-
subdivisionCode:
126-
type: string
127-
type: object
128-
healthCheckID:
129-
type: string
130-
multiValueAnswer:
131-
type: boolean
132-
name:
133-
type: string
134-
region:
135-
type: string
136-
resourceRecords:
137-
items:
138-
description: |-
139-
Information specific to the resource record.
140-
141-
If you're creating an alias resource record set, omit ResourceRecord.
142-
properties:
143-
value:
144-
type: string
145-
type: object
146-
type: array
147-
setIdentifier:
148-
type: string
149-
trafficPolicyInstanceID:
150-
type: string
151-
ttl:
152-
format: int64
153-
type: integer
154-
type_:
155-
type: string
156-
weight:
157-
format: int64
158-
type: integer
159-
type: object
160-
type: object
161-
type: array
162-
comment:
163-
type: string
164-
type: object
16569
cidrRoutingConfig:
16670
description: |-
16771
The object that is specified in resource record set object when you are linking

0 commit comments

Comments
 (0)