Skip to content

Commit a606fd1

Browse files
authored
Merge pull request #156 from a-hilaly/rm-rolearn
Update `AWSResourceManagerFactory` to include `roleARN` paramter
2 parents 63238ad + 9fdb7f0 commit a606fd1

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

mocks/pkg/types/aws_resource_manager_factory.go

+9-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/runtime/adoption_reconciler.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ func (r *adoptionReconciler) reconcile(ctx context.Context, req ctrlrt.Request)
168168
ackrtlog.InfoAdoptedResource(r.log, res, "starting adoption reconciliation")
169169

170170
rm, err := rmf.ManagerFor(
171-
r.cfg, r.log, r.metrics, r, sess, acctID, region,
171+
r.cfg, r.log, r.metrics, r, sess, acctID, region, roleARN,
172172
)
173173
if err != nil {
174174
return err

pkg/runtime/reconciler.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ func (r *resourceReconciler) Reconcile(ctx context.Context, req ctrlrt.Request)
285285
)
286286

287287
rm, err := r.rmf.ManagerFor(
288-
r.cfg, r.log, r.metrics, r, sess, acctID, region,
288+
r.cfg, r.log, r.metrics, r, sess, acctID, region, roleARN,
289289
)
290290
if err != nil {
291291
return ctrlrt.Result{}, err

pkg/types/aws_resource_manager.go

+1
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ type AWSResourceManagerFactory interface {
106106
*session.Session,
107107
ackv1alpha1.AWSAccountID,
108108
ackv1alpha1.AWSRegion,
109+
ackv1alpha1.AWSResourceName,
109110
) (AWSResourceManager, error)
110111
// IsAdoptable returns true if the resource is able to be adopted
111112
IsAdoptable() bool

0 commit comments

Comments
 (0)