Added test case for dependent check

Signed-off-by: Rahul Parande <rparande@amazon.com>

Author: Rahul Parande

contrib/babelfishpg_tsql/src/pl_handler.c

@@ -4951,8 +4951,8 @@ get_old_view_acl(Oid oldViewOid)
 					errmsg("cache lookup failed for relation %u", oldViewOid)));
 
 	aclDatum = SysCacheGetAttr(RELOID, tuple, Anum_pg_class_relacl, &isNull);
-	if (!isNull)
-		oldViewAcl = DatumGetAclPCopy(aclDatum);
+	Assert(!isNull);
+	oldViewAcl = DatumGetAclPCopy(aclDatum);
 
 	ReleaseSysCache(tuple);
 

test/JDBC/expected/alter-view-vu-cleanup.out

@@ -74,6 +74,15 @@ GO
 DROP VIEW IF EXISTS guest.alter_v1;
 GO
 
+DROP VIEW IF EXISTS alter_v25;
+GO
+
+DROP VIEW IF EXISTS alter_v24;
+GO
+
+DROP VIEW IF EXISTS alter_v26;
+GO
+
 -- Drop the tables
 DROP TABLE IF EXISTS alter_t;
 GO

test/JDBC/expected/alter-view-vu-prepare.out

@@ -55,3 +55,12 @@ GO
 
 CREATE VIEW alter_v8 AS SELECT a, b, c, d, e FROM alter_t4;
 GO
+
+CREATE VIEW alter_v24 AS SELECT a, b, c, d FROM alter_t;
+GO
+
+CREATE VIEW alter_v25 AS SELECT a, b FROM alter_v24;
+GO
+
+CREATE VIEW alter_v26 AS SELECT a, b, c, d FROM alter_t;
+GO

test/JDBC/expected/alter-view-vu-verify.out

@@ -373,6 +373,49 @@ int#!#varchar
 ~~END~~
 
 
+-- Alter View having dependent view [Error]
+ALTER VIEW alter_v24 AS SELECT a,b FROM alter_t;
+GO
+~~ERROR (Code: 33557097)~~
+
+~~ERROR (Message: cannot drop view alter_v24 because other objects depend on it)~~
+
+
+SELECT * FROM alter_v24;
+GO
+~~START~~
+int#!#varchar#!#varchar#!#int
+1#!#a#!#a#!#1
+2#!#b#!#b#!#2
+3#!#c#!#c#!#3
+4#!#d#!#d#!#4
+5#!#e#!#e#!#5
+6#!#f#!#f#!#6
+7#!#g#!#g#!#7
+8#!#h#!#h#!#8
+9#!#i#!#i#!#9
+10#!#j#!#j#!#10
+~~END~~
+
+
+-- Verify dependent view after Alter on underlying view fails
+SELECT * FROM alter_v25;
+GO
+~~START~~
+int#!#varchar
+1#!#a
+2#!#b
+3#!#c
+4#!#d
+5#!#e
+6#!#f
+7#!#g
+8#!#h
+9#!#i
+10#!#j
+~~END~~
+
+
 -- Change int to bigint
 ALTER VIEW alter_v7 AS SELECT CAST(a AS bigint) AS a, b, c, d, e FROM alter_t4;
 GO

test/JDBC/input/alter/alter-view-vu-cleanup.sql

@@ -74,6 +74,15 @@ GO
 DROP VIEW IF EXISTS guest.alter_v1;
 GO
 
+DROP VIEW IF EXISTS alter_v25;
+GO
+
+DROP VIEW IF EXISTS alter_v24;
+GO
+
+DROP VIEW IF EXISTS alter_v26;
+GO
+
 -- Drop the tables
 DROP TABLE IF EXISTS alter_t;
 GO

test/JDBC/input/alter/alter-view-vu-prepare.sql

@@ -44,4 +44,13 @@ CREATE VIEW alter_v7 AS SELECT a, b, c, d, e FROM alter_t4;
 GO
 
 CREATE VIEW alter_v8 AS SELECT a, b, c, d, e FROM alter_t4;
-GO
+GO
+
+CREATE VIEW alter_v24 AS SELECT a, b, c, d FROM alter_t;
+GO
+
+CREATE VIEW alter_v25 AS SELECT a, b FROM alter_v24;
+GO
+
+CREATE VIEW alter_v26 AS SELECT a, b, c, d FROM alter_t;
+GO

test/JDBC/input/alter/alter-view-vu-verify.sql

@@ -127,6 +127,17 @@ GO
 SELECT * FROM dbo.alter_v1;
 GO
 
+-- Alter View having dependent view [Error]
+ALTER VIEW alter_v24 AS SELECT a,b FROM alter_t;
+GO
+
+SELECT * FROM alter_v24;
+GO
+
+-- Verify dependent view after Alter on underlying view fails
+SELECT * FROM alter_v25;
+GO
+
 -- Change int to bigint
 ALTER VIEW alter_v7 AS SELECT CAST(a AS bigint) AS a, b, c, d, e FROM alter_t4;
 GO