remove ErrAlreadyExist

Author: emar-kar

configparser.go

@@ -18,8 +18,6 @@ var (
 	interpolater  = regexp.MustCompile(`%\(([^)]*)\)s`)
 )
 
-var ErrAlreadyExist = errors.New("already exist")
-
 var boolMapping = map[string]bool{
 	"1":     true,
 	"true":  true,
@@ -255,7 +253,7 @@ func (p *ConfigParser) ParseReader(in io.Reader) error {
 			} else {
 				// If key was defined, but current line does not start with any of the
 				// multiline prefixes or it is an empty line which is not allowed within values,
-				//  then it counts as the value parsing is finished and it can be added
+				// then it counts as the value parsing is finished and it can be added
 				// to the current section.
 				if err := curSect.Add(key, value); err != nil {
 					return fmt.Errorf("failed to add %q = %q: %w", key, value, err)
@@ -279,7 +277,9 @@ func (p *ConfigParser) ParseReader(in io.Reader) error {
 				curSect = newSection(section)
 				p.config[section] = curSect
 			} else if p.opt.strict {
-				return fmt.Errorf("section %q error: %w", section, ErrAlreadyExist)
+				return fmt.Errorf(
+					"section %q already exists and strict flag was set", section,
+				)
 			}
 
 			// Since section was defined on current line, may continue.

methods.go

@@ -273,7 +273,10 @@ func (p *ConfigParser) inOptions(key string) error {
 
 	for _, o := range opts {
 		if key == o {
-			return fmt.Errorf("option %q error: %w", key, ErrAlreadyExist)
+			return fmt.Errorf(
+				"option %q already exists and strict flag was set",
+				key,
+			)
 		}
 	}
 

options_test.go

@@ -199,7 +199,7 @@ func (s *ConfigParserSuite) TestStrictOptDuplicateSection(c *C) {
 	)
 
 	c.Assert(err, NotNil)
-	c.Assert(err.Error(), Equals, "section \"dubl\" error: already exist")
+	c.Assert(err.Error(), Equals, "section \"dubl\" already exists and strict flag was set")
 }
 
 // TestStrictOptDuplicateValue tests strict option with value duplicate.
@@ -210,7 +210,7 @@ func (s *ConfigParserSuite) TestStrictOptDuplicateValue(c *C) {
 	)
 
 	c.Assert(err, NotNil)
-	c.Assert(err.Error(), Equals, "option \"dubl\" error: already exist")
+	c.Assert(err.Error(), Equals, "option \"dubl\" already exists and strict flag was set")
 }
 
 // TestStrictOptDuplicateEmptyValue tests strict option with empty value duplicate.
@@ -222,7 +222,7 @@ func (s *ConfigParserSuite) TestStrictOptDuplicateEmptyValue(c *C) {
 	)
 
 	c.Assert(err, NotNil)
-	c.Assert(err.Error(), Equals, "option \"dubl\" error: already exist")
+	c.Assert(err.Error(), Equals, "option \"dubl\" already exists and strict flag was set")
 }
 
 // TestAllowEmptyLines tests empty lines as part of the value.