Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

Commit 4fe23f0

Browse files
author
Benjamin Scholtysik (Reimold)
authored
Merge pull request #444 from bitstadium/release/500-beta-1
Release/500 beta 1
2 parents cdde5d1 + e711965 commit 4fe23f0

11 files changed

+52
-96
lines changed

Classes/BITAttributedLabel.m

+4
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,12 @@
5353
static const NSTextAlignment BITTextAlignmentNatural = NSTextAlignmentNatural;
5454

5555
static const NSLineBreakMode BITLineBreakByWordWrapping = NSLineBreakByWordWrapping;
56+
57+
#pragma clang diagnostic push
58+
#pragma clang diagnostic ignored "-Wunused-const-variable"
5659
static const NSLineBreakMode BITLineBreakByCharWrapping = NSLineBreakByCharWrapping;
5760
static const NSLineBreakMode BITLineBreakByClipping = NSLineBreakByClipping;
61+
#pragma clang diagnostic pop
5862
static const NSLineBreakMode BITLineBreakByTruncatingHead = NSLineBreakByTruncatingHead;
5963
static const NSLineBreakMode BITLineBreakByTruncatingMiddle = NSLineBreakByTruncatingMiddle;
6064
static const NSLineBreakMode BITLineBreakByTruncatingTail = NSLineBreakByTruncatingTail;

Classes/BITFeedbackManager.m

+1-32
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131

3232
#if HOCKEYSDK_FEATURE_FEEDBACK
3333

34-
#import <AssetsLibrary/AssetsLibrary.h>
3534
#import <Photos/Photos.h>
3635

3736
#import "HockeySDKPrivate.h"
@@ -1262,37 +1261,7 @@ - (void)requestLatestImageWithCompletionHandler:(BITLatestImageFetchCompletionBl
12621261
// Safeguard in case the dev hasn't set the NSPhotoLibraryUsageDescription in their Info.plist
12631262
if (![self isiOS10PhotoPolicySet]) {return;}
12641263

1265-
// Only available from iOS 8 up
1266-
id phImageManagerClass = NSClassFromString(@"PHImageManager");
1267-
if (phImageManagerClass) {
1268-
[self fetchLatestImageUsingPhotoLibraryWithCompletionHandler:completionHandler];
1269-
} else {
1270-
[self fetchLatestImageUsingAssetsLibraryWithCompletionHandler:completionHandler];
1271-
}
1272-
}
1273-
1274-
- (void)fetchLatestImageUsingAssetsLibraryWithCompletionHandler:(BITLatestImageFetchCompletionBlock)completionHandler {
1275-
#pragma clang diagnostic push
1276-
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
1277-
ALAssetsLibrary *library = [[ALAssetsLibrary alloc] init];
1278-
[library enumerateGroupsWithTypes:ALAssetsGroupSavedPhotos usingBlock:^(ALAssetsGroup *group, BOOL *stop) {
1279-
1280-
[group setAssetsFilter:[ALAssetsFilter allPhotos]];
1281-
1282-
[group enumerateAssetsWithOptions:NSEnumerationReverse usingBlock:^(ALAsset *alAsset, NSUInteger __unused index, BOOL *innerStop) {
1283-
1284-
if (alAsset) {
1285-
ALAssetRepresentation *representation = [alAsset defaultRepresentation];
1286-
UIImage *latestPhoto = [UIImage imageWithCGImage:[representation fullScreenImage]];
1287-
1288-
completionHandler(latestPhoto);
1289-
1290-
*stop = YES;
1291-
*innerStop = YES;
1292-
}
1293-
}];
1294-
} failureBlock:nil];
1295-
#pragma clang diagnostic pop
1264+
[self fetchLatestImageUsingPhotoLibraryWithCompletionHandler:completionHandler];
12961265
}
12971266

12981267
- (void)fetchLatestImageUsingPhotoLibraryWithCompletionHandler:(BITLatestImageFetchCompletionBlock)completionHandler NS_AVAILABLE_IOS(8_0) {

Documentation/Guides/Changelog.md

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
## 5.0.0-beta.1
2+
3+
This version drops support for iOS 7. There is not other breaking change at this point.
4+
5+
- [IMPROVEMENT] The code has been cleaned up as we have decided to drop support for iOS 7.
6+
- [IMPROVEMENT] `properties` of type `NSString` now use the `copy` attribute.
7+
- [BUGFIX] The logic that makes sure that the for HockeySDK-iOS is excluded from backups was changed to make sure it doesn't block app launch [#443](https://github.com/bitstadium/HockeySDK-iOS/pull/443).
8+
19
## 4.1.6
210

311
- [BUGFIX] Fixed a string in the Italian translation [#430](https://github.com/bitstadium/HockeySDK-iOS/pull/430).

Documentation/Guides/Installation & Setup.md

+22-24
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
[![Version](http://cocoapod-badges.herokuapp.com/v/HockeySDK/badge.png)](http://cocoadocs.org/docsets/HockeySDK)
44
[![Slack Status](https://slack.hockeyapp.net/badge.svg)](https://slack.hockeyapp.net)
55

6-
## Version 4.1.6
6+
## Version 5.0.0-beta.1
77

8-
- [Changelog](http://www.hockeyapp.net/help/sdk/ios/4.1.6/docs/docs/Changelog.html)
8+
- [Changelog](http://www.hockeyapp.net/help/sdk/ios/5.0.0-beta.1/docs/docs/Changelog.html)
99

1010
**NOTE** If your are using the binary integration of our SDK, make sure that the `HockeySDKResources.bundle` inside the `HockeySDK.embeddedframework`-folder has been added to your application.
1111

@@ -84,7 +84,7 @@ Please see the "[How to create a new app](http://support.hockeyapp.net/kb/about-
8484

8585
From our experience, 3rd-party libraries usually reside inside a subdirectory (let's call our subdirectory `Vendor`), so if you don't have your project organized with a subdirectory for libraries, now would be a great start for it. To continue our example, create a folder called `Vendor` inside your project directory and move the unzipped `HockeySDK-iOS`-folder into it.
8686

87-
The SDK comes in four flavours:
87+
The SDK comes in four flavors:
8888

8989
* Default SDK without Feedback: `HockeySDK.embeddedframework`
9090
* Full featured SDK with Feedback: `HockeySDK.embeddedframework` in the subfolder `HockeySDKAllFeatures`.
@@ -97,7 +97,7 @@ Our examples will use the **default** SDK (`HockeySDK.embeddedframework`).
9797

9898
### 2.4 Add the SDK to the project in Xcode
9999

100-
> We recommend to use Xcode's group-feature to create a group for 3rd-party-libraries similar to the structure of our files on disk. For example, similar to the file structure in 2.3 above, our projects have a group called `Vendor`.
100+
> We recommend using Xcode's group-feature to create a group for 3rd-party-libraries similar to the structure of our files on disk. For example, similar to the file structure in 2.3 above, our projects have a group called `Vendor`.
101101
102102
1. Make sure the `Project Navigator` is visible (⌘+1).
103103
2. Drag & drop `HockeySDK.embeddedframework` from your `Finder` to the `Vendor` group in `Xcode` using the `Project Navigator` on the left side.
@@ -173,7 +173,7 @@ Our examples will use the **default** SDK (`HockeySDK.embeddedframework`).
173173
```
174174

175175

176-
*Note:* The SDK is optimized to defer everything possible to a later time while making sure e.g. crashes on startup can also be caught and each module executes other code with a delay some seconds. This ensures that `applicationDidFinishLaunching` will process as fast as possible and the SDK will not block the startup sequence resulting in a possible kill by the watchdog process.
176+
*Note:* The SDK is optimized to defer everything possible to a later time while making sure e.g. crashes on start-up can also be caught and each module executes other code with a delay some seconds. This ensures that `applicationDidFinishLaunching` will process as fast as possible and the SDK will not block the start-up sequence resulting in a possible kill by the watchdog process.
177177

178178

179179
**Congratulation, now you're all set to use HockeySDK!**
@@ -192,7 +192,6 @@ If you are working with an older project which doesn't support clang modules yet
192192
4. Expand `Link Binary With Libraries`.
193193
5. Add the following system frameworks, if they are missing:
194194
1. Default SDK:
195-
+ `AssetsLibrary`
196195
+ `CoreText`
197196
+ `CoreGraphics`
198197
+ `Foundation`
@@ -205,7 +204,6 @@ If you are working with an older project which doesn't support clang modules yet
205204
+ `libc++`
206205
+ `libz`
207206
2. SDK with all features:
208-
+ `AssetsLibrary`
209207
+ `CoreText`
210208
+ `CoreGraphics`
211209
+ `Foundation`
@@ -230,7 +228,7 @@ If you are working with an older project which doesn't support clang modules yet
230228
+ `SystemConfiguration`
231229
+ `libc++`
232230

233-
Note that this also means that you can't use the `@import` syntax mentioned in the [Modify Code](#modify) section but have to stick to the old `#import <HockeySDK/HockeySDK.h>`.
231+
Note that not using clang modules also means that you can't use the `@import` syntax mentioned in the [Modify Code](#modify) section but have to stick to the old `#import <HockeySDK/HockeySDK.h>` imports.
234232

235233
<a id="cocoapods"></a>
236234
### 3.2 CocoaPods
@@ -276,7 +274,7 @@ pod "HockeySDK", :subspecs => ['CrashOnlyExtensionsLib']
276274

277275
#### 3.2.2 Source Integration Options
278276

279-
Alternatively you can integrate the SDK by source if you want to do modifications or want a different feature set. The following entry will integrate the SDK:
277+
Alternatively, you can integrate the SDK by source if you want to do modifications or want a different feature set. The following entry will integrate the SDK:
280278

281279
```ruby
282280
pod "HockeySDK-Source"
@@ -404,7 +402,7 @@ The following points need to be considered to use HockeySDK with WatchKit 1 Exte
404402
<a name="crashreporting"></a>
405403
### 3.6 Crash Reporting
406404

407-
The following options only show some of possibilities to interact and fine-tune the crash reporting feature. For more please check the full documentation of the `BITCrashManager` class in our [documentation](#documentation).
405+
The following options only show some of the possibilities to interact and fine-tune the crash reporting feature. For more please check the full documentation of the `BITCrashManager` class in our [documentation](#documentation).
408406

409407
#### 3.6.1 Disable Crash Reporting
410408
The HockeySDK enables crash reporting **per default**. Crashes will be immediately sent to the server the next time the app is launched.
@@ -435,15 +433,15 @@ Crashes are send the next time the app starts. If `crashManagerStatus` is set to
435433

436434
The SDK is not sending the reports right when the crash happens deliberately, because if is not safe to implement such a mechanism while being async-safe (any Objective-C code is _NOT_ async-safe!) and not causing more danger like a deadlock of the device, than helping. We found that users do start the app again because most don't know what happened, and you will get by far most of the reports.
437435

438-
Sending the reports on startup is done asynchronously (non-blocking). This is the only safe way to ensure that the app won't be possibly killed by the iOS watchdog process, because startup could take too long and the app could not react to any user input when network conditions are bad or connectivity might be very slow.
436+
Sending the reports on start-up is done asynchronously (non-blocking). This is the only safe way to ensure that the app won't be possibly killed by the iOS watchdog process, because start-up could take too long and the app could not react to any user input when network conditions are bad or connectivity might be very slow.
439437

440438
#### 3.6.3 Mach Exception Handling
441439

442440
By default the SDK is using the safe and proven in-process BSD Signals for catching crashes. This option provides an option to enable catching fatal signals via a Mach exception server instead.
443441

444-
We strongly advice _NOT_ to enable Mach exception handler in release versions of your apps!
442+
We strongly advise _NOT_ to enable Mach exception handler in release versions of your apps!
445443

446-
*Warning:* The Mach exception handler executes in-process, and will interfere with debuggers when they attempt to suspend all active threads (which will include the Mach exception handler). Mach-based handling should _NOT_ be used when a debugger is attached. The SDK will not enabled catching exceptions if the app is started with the debugger running. If you attach the debugger during runtime, this may cause issues the Mach exception handler is enabled!
444+
*Warning:* The Mach exception handler executes in-process, and will interfere with debuggers when they attempt to suspend all active threads (which will include the Mach exception handler). Mach-based handling should _NOT_ be used when a debugger is attached. The SDK will not enable catching exceptions if the app is started with the debugger running. If you attach the debugger during runtime, this may cause issues the Mach exception handler is enabled!
447445

448446
```objc
449447
[[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"];
@@ -533,7 +531,7 @@ metricsManager.trackEventWithName(eventName)
533531

534532
#### 3.7.2 Attaching custom properties and measurements to a custom event
535533

536-
It's possible to attach properties and/or measurements to a custom event. There is one limitation to attaching properties and measurements. They currently don't show up in the HockeyApp dashboard but you have to link your app to Application Insights to be able to query them. Please have a look at [our blogpost](https://www.hockeyapp.net/blog/2016/08/30/custom-events-public-preview.html) to find out how to do that.
534+
It's possible to attach properties and/or measurements to a custom event. There is one limitation to attaching properties and measurements. They currently don't show up in the HockeyApp dashboard but you have to link your app to Application Insights to be able to query them. Please have a look at [our blog post](https://www.hockeyapp.net/blog/2016/08/30/custom-events-public-preview.html) to find out how to do that.
537535

538536
- Properties have to be a string.
539537
- Measurements have to be of a numeric type.
@@ -570,15 +568,15 @@ As of HockeySDK 4.1.1, Feedback is no longer part of the default SDK. To use fee
570568

571569
#### 3.8.1 Integrate the full-featured SDK.
572570

573-
If you're integrating the binary yourself, use the `HockeySDK.embeddedframework` in the subfolder `HockeySDKAllFeatures`. If you're using Cocoapods, use
571+
If you're integrating the binary yourself, use the `HockeySDK.embeddedframework` in the subfolder `HockeySDKAllFeatures`. If you're using CocoaPods, use
574572

575573
```ruby
576574
pod "HockeySDK", :subspecs => ['AllFeaturesLib']
577575
```
578576

579577
in your podfile.
580578

581-
`BITFeedbackManager` lets your users communicate directly with you via the app and an integrated user interface. It provides a single threaded discussion with a user running your app. This feature is only enabled, if you integrate the actual view controllers into your app.
579+
`BITFeedbackManager` lets your users communicate directly with you via the app and an integrated user interface. It provides a single threaded discussion with a user running your app. This feature is only enabled if you integrate the actual view controllers into your app.
582580

583581
You should never create your own instance of `BITFeedbackManager` but use the one provided by the `[BITHockeyManager sharedHockeyManager]`:
584582

@@ -600,7 +598,7 @@ If the value is missing from your `Info.plist`, the SDK will disable attaching p
600598

601599
This is the HockeySDK module for handling app updates when having your app released in the App Store.
602600

603-
When an update is detected, this module will show an alert asking the user if he/she wants to update or ignore this version. If update was chosen, it will open the apps page in the app store app.
601+
When an update is detected, this module will show an alert asking the user if he/she wants to update or ignore this version. If the update was chosen, it will open the apps page in the app store app.
604602

605603
By default this module is **NOT** enabled! To enable it use the following code:
606604

@@ -619,9 +617,9 @@ Please check the [documentation](#documentation) of the `BITStoreUpdateManager`
619617
<a name="betaupdates"></a>
620618
### 3.10 In-App-Updates (Beta & Enterprise only)
621619
622-
The following options only show some of possibilities to interact and fine-tune the update feature when using Ad-Hoc or Enterprise provisioning profiles. For more please check the full documentation of the `BITUpdateManager` class in our [documentation](#documentation).
620+
The following options only show some of the possibilities to interact and fine-tune the update feature when using Ad-Hoc or Enterprise provisioning profiles. For more please check the full documentation of the `BITUpdateManager` class in our [documentation](#documentation).
623621
624-
The feature handles version updates, presents update and version information in a App Store like user interface, collects usage information and provides additional authorization options when using Ad-Hoc provisioning profiles.
622+
The feature handles version updates, presents the update and version information in a App Store like user interface, collects usage information and provides additional authorization options when using Ad-Hoc provisioning profiles.
625623
626624
This module automatically disables itself when running in an App Store build by default!
627625
@@ -655,7 +653,7 @@ To check if data is send properly to HockeyApp and also see some additional SDK
655653
<a id="documentation"></a>
656654
## 4. Documentation
657655
658-
Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/4.1.6/index.html).
656+
Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/5.0.0-beta.1/index.html).
659657
660658
<a id="troubleshooting"></a>
661659
## 5.Troubleshooting
@@ -669,7 +667,7 @@ Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/
669667
Make sure none of the following files are copied into your app bundle, check under app target, `Build Phases`, `Copy Bundle Resources` or in the `.app` bundle after building:
670668
671669
- `HockeySDK.framework` (except if you build a dynamic framework version of the SDK yourself!)
672-
- `de.bitstadium.HockeySDK-iOS-4.1.6.docset`
670+
- `de.bitstadium.HockeySDK-iOS-5.0.0-beta.1.docset`
673671
674672
### Features are not working as expected
675673
@@ -697,9 +695,9 @@ We're looking forward to your contributions via pull requests on our [GitHub rep
697695
698696
* A Mac running the latest version of OS X
699697
* Get the latest Xcode from the Mac App Store
700-
* [AppleDoc](https://github.com/tomaz/appledoc)
701-
* [CocoaPods](https://cocoapods.org/)
702-
* [Carthage](https://github.com/Carthage/Carthage)
698+
* [Jazzy](https://github.com/realm/jazzy) to generate documentation
699+
* [CocoaPods](https://cocoapods.org/) to test integration with CocoaPods.
700+
* [Carthage](https://github.com/Carthage/Carthage) to test integration with Carthage.
703701
704702
<a id="codeofconduct"></a>
705703
### 6.2 Code of Conduct

Documentation/HockeySDK/.jazzy.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ sdk: iphonesimulator
55
theme: ../Themes/apple
66

77
module: HockeySDK
8-
module_version: 4.1.6
8+
module_version: 5.0.0-beta.1
99
author: Microsoft Corp
1010
author_url: https://www.microsoft.com
1111

HockeySDK-Source.podspec

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'HockeySDK-Source'
3-
s.version = '4.1.6'
3+
s.version = '5.0.0-beta.1'
44

55
s.summary = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.'
66
s.description = <<-DESC
@@ -25,7 +25,7 @@ Pod::Spec.new do |s|
2525
s.frameworks = 'AssetsLibrary', 'CoreGraphics', 'CoreTelephony', 'CoreText', 'MobileCoreServices', 'Photos', 'QuartzCore', 'QuickLook', 'Security', 'SystemConfiguration', 'UIKit'
2626
s.libraries = 'c++', 'z'
2727
s.vendored_frameworks = 'Vendor/CrashReporter.framework'
28-
s.pod_target_xcconfig = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_C_VERSION="\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"101\\"" BITHOCKEY_C_BUILD="\\"101\\""} }
28+
s.pod_target_xcconfig = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_C_VERSION="\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"102\\"" BITHOCKEY_C_BUILD="\\"102\\""} }
2929
s.resource_bundle = { 'HockeySDKResources' => ['Resources/*.png', 'Resources/*.lproj'] }
3030
s.preserve_paths = 'Resources', 'Support'
3131
s.private_header_files = 'Classes/*Private.h'

HockeySDK.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'HockeySDK'
3-
s.version = '4.1.6'
3+
s.version = '5.0.0-beta.1'
44

55
s.summary = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.'
66
s.description = <<-DESC

0 commit comments

Comments
 (0)