Skip to content

Commit 0af0f74

Browse files
sid-acrylchakru-r
authored andcommitted
fix(ingest/tableau): apply page_size regardless of object count (datahub-project#12026)
1 parent f43be35 commit 0af0f74

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

metadata-ingestion/src/datahub/ingestion/source/tableau/tableau_common.py

-1
Original file line numberDiff line numberDiff line change
@@ -979,7 +979,6 @@ def get_filter_pages(query_filter: dict, page_size: int) -> List[dict]:
979979
len(query_filter.keys()) == 1
980980
and query_filter.get(c.ID_WITH_IN)
981981
and isinstance(query_filter[c.ID_WITH_IN], list)
982-
and len(query_filter[c.ID_WITH_IN]) > 100 * page_size
983982
):
984983
ids = query_filter[c.ID_WITH_IN]
985984
filter_pages = [

metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"site": "acryl",
6161
"projects": ["default", "Project 2", "Samples"],
6262
"extract_project_hierarchy": False,
63-
"page_size": 10,
63+
"page_size": 1000,
6464
"ingest_tags": True,
6565
"ingest_owner": True,
6666
"ingest_tables_external": True,
@@ -673,7 +673,7 @@ def test_tableau_ingest_with_platform_instance(
673673
"site": "acryl",
674674
"platform_instance": "acryl_site1",
675675
"projects": ["default", "Project 2"],
676-
"page_size": 10,
676+
"page_size": 1000,
677677
"ingest_tags": True,
678678
"ingest_owner": True,
679679
"ingest_tables_external": True,

0 commit comments

Comments
 (0)