Remove the externallib dependency

Author: wo14580

auth.php

@@ -26,8 +26,8 @@
 
 use auth_userkey\core_userkey_manager;
 use auth_userkey\userkey_manager_interface;
+use core_external\external_value;
 
-require_once($CFG->libdir . "/externallib.php");
 require_once($CFG->libdir.'/authlib.php');
 require_once($CFG->dirroot . '/user/lib.php');
 

externallib.php

@@ -24,7 +24,11 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->libdir . "/externallib.php");
+use core_external\external_value;
+use core_external\external_api;
+use core_external\external_function_parameters;
+use core_external\external_single_structure;
+
 require_once($CFG->dirroot . "/webservice/lib.php");
 require_once($CFG->dirroot . "/auth/userkey/auth.php");
 

tests/auth_plugin_test.php

@@ -21,7 +21,7 @@
 use stdClass;
 use invalid_parameter_exception;
 use moodle_exception;
-use external_value;
+use core_external\external_value;
 
 /**
  * Tests for auth_plugin_userkey class.
@@ -57,7 +57,6 @@ class auth_plugin_test extends advanced_testcase {
     public function setUp(): void {
         global $CFG;
 
-        require_once($CFG->libdir . "/externallib.php");
         require_once($CFG->dirroot . '/auth/userkey/tests/fake_userkey_manager.php');
         require_once($CFG->dirroot . '/auth/userkey/auth.php');
         require_once($CFG->dirroot . '/user/lib.php');

tests/externallib_test.php

@@ -19,7 +19,7 @@
 use advanced_testcase;
 use webservice_access_exception;
 use auth_userkey_external;
-use external_api;
+use core_external\external_api;
 use invalid_parameter_exception;
 use required_capability_exception;
 use context_system;
@@ -37,17 +37,16 @@ class externallib_test extends advanced_testcase {
     /**
      * User object.
      *
-     * @var
+     * @var stdClass
      */
-    protected $user = array();
+    protected $user;
 
     /**
      * Initial set up.
      */
     public function setUp(): void {
         global $CFG;
 
-        require_once($CFG->libdir . "/externallib.php");
         require_once($CFG->dirroot . '/auth/userkey/externallib.php');
 
         $this->resetAfterTest();