Issue #66 Replace from raw template to rendered one if possible

Author: TomoTsuyuki

classes/search/cmsfield.php

@@ -18,6 +18,9 @@
 
 defined('MOODLE_INTERNAL') || die();
 
+use mod_cms\local\model\cms;
+use mod_cms\local\renderer;
+
 require_once($CFG->dirroot . '/mod/cms/lib.php');
 
 /**
@@ -95,7 +98,6 @@ public function get_document_recordset($modifiedfrom = 0, \context $context = nu
      * @return \core_search\document
      */
     public function get_document($record, $options = []) {
-        global $DB;
         try {
             $cm = $this->get_cm('cms', $record->id, $record->courseid);
             $context = \context_module::instance($cm->id);
@@ -130,9 +132,21 @@ public function get_document($record, $options = []) {
             $value = $record->value;
             $valueformat = $record->valueformat;
         }
+
         // Add mustache template to value.
         if (!empty($defaultvalues[$record->typeid]->mustache)) {
-            $value .= ' ' . $defaultvalues[$record->typeid]->mustache;
+            $cms = new cms($cm->instance);
+            $renderer = new renderer($cms);
+            ob_start();
+            try {
+                // Indexer uses "Empty" session, it may get an error from rendering.
+                $value .= $renderer->get_html();
+            } catch (\Exception $e) {
+                // Use template when an error occurs.
+                $value .= ' ' . $defaultvalues[$record->typeid]->mustache;
+            }
+            // Do not show any errors from rendering.
+            ob_end_clean();
             if (empty($title)) {
                 $title = $defaultvalues[$record->typeid]->name;
             }

tests/search/search_test.php

@@ -190,12 +190,6 @@ public function test_get_document_recordset(): void {
             $this->assertEquals($this->field->get('name'), $doc->get('title'));
             $this->assertStringContainsString($data->value, $doc->get('content'));
             $this->assertStringContainsString($this->cmstype->get('mustache'), $doc->get('content'));
-
-            // Static caches are working.
-            $dbreads = $DB->perf_get_reads();
-            $doc = $searcharea->get_document($record);
-            $this->assertEquals($dbreads, $DB->perf_get_reads());
-            $this->assertInstanceOf('\core_search\document', $doc);
             $count++;
         }
         $this->assertEquals(1, $count);