Issue #66 Use parent functions and rename search class name

Author: TomoTsuyuki

classes/search/cmsfield.php classes/search/activity.php

@@ -31,17 +31,7 @@
  * @copyright  2024 Catalyst IT
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class cmsfield extends \core_search\base_activity {
-
-    /**
-     * @var array Internal quick static cache.
-     */
-    protected $cmsdata = [];
-
-    /**
-     * @var array Internal quick static cache.
-     */
-    protected $defaultvalues = null;
+class activity extends \core_search\base_activity {
 
     /**
      * Returns the document associated with this data id.
@@ -89,76 +79,6 @@ public function get_document($record, $options = []) {
         return $doc;
     }
 
-    /**
-     * Whether the user can access the document or not.
-     *
-     * @param int $id data id
-     * @return bool
-     */
-    public function check_access($id) {
-        try {
-            $data = $this->get_data($id);
-            $cminfo = $this->get_cm('cms', $data->id, $data->courseid);
-            $context = \context_module::instance($cminfo->id);
-        } catch (\dml_missing_record_exception $ex) {
-            return \core_search\manager::ACCESS_DELETED;
-        } catch (\dml_exception $ex) {
-            return \core_search\manager::ACCESS_DENIED;
-        }
-
-        // Recheck uservisible although it should have already been checked in core_search.
-        if ($cminfo->uservisible === false) {
-            return \core_search\manager::ACCESS_DENIED;
-        }
-
-        if (!has_capability('mod/cms:view', $context)) {
-            return \core_search\manager::ACCESS_DENIED;
-        }
-
-        return \core_search\manager::ACCESS_GRANTED;
-    }
-
-    /**
-     * Link to the cms.
-     *
-     * @param \core_search\document $doc
-     * @return \moodle_url
-     */
-    public function get_doc_url(\core_search\document $doc) {
-        $contextmodule = \context::instance_by_id($doc->get('contextid'));
-        $cm = get_coursemodule_from_id('cms', $contextmodule->instanceid, $doc->get('courseid'), true);
-        return new \moodle_url('/course/view.php', ['id' => $doc->get('courseid'), 'section' => $cm->sectionnum]);
-    }
-
-    /**
-     * Link to the cms.
-     *
-     * @param \core_search\document $doc
-     * @return \moodle_url
-     */
-    public function get_context_url(\core_search\document $doc) {
-        $contextmodule = \context::instance_by_id($doc->get('contextid'));
-        return new \moodle_url('/mod/cms/view.php', ['id' => $contextmodule->instanceid]);
-    }
-
-    /**
-     * Returns the specified data from its internal cache.
-     *
-     * @throws \dml_missing_record_exception
-     * @param int $id
-     * @return stdClass
-     */
-    protected function get_data($id) {
-        global $DB;
-        if (empty($this->cmsdata[$id])) {
-            $sql = "SELECT mc.id, mc.course AS courseid
-                      FROM {cms} mc
-                     WHERE mc.id = :id";
-            $this->cmsdata[$id] = $DB->get_record_sql($sql, ['id' => $id], MUST_EXIST);
-        }
-        return $this->cmsdata[$id];
-    }
-
     /**
      * Returns true if this area uses file indexing.
      *

lang/en/cms.php

@@ -104,7 +104,7 @@
 $string['error:no_config_hash'] = 'Module {$a} has no config hash.';
 
 // Search strings.
-$string['search:cmsfield'] = 'CMS';
+$string['search:activity'] = 'CMS - activity information';
 
 // Site datasource strings.
 $string['site:displayname'] = 'Site Info';

version.php

@@ -25,7 +25,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version = 2024090300;
+$plugin->version = 2024090301;
 $plugin->requires = 2022112800; // Moodle 4.1 and above.
 $plugin->supported = [401, 401]; // Moodle 4.1.
 $plugin->component = 'mod_cms';