Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role condition doesn't respect "including children (categories and courses)" #132

Open
dmitriim opened this issue Feb 23, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@dmitriim
Copy link
Member

Seem like if you set "including children (categories and courses)" for the Role condition it only checks allocation in direct subcategories (excluding children of subcategories and courses ).

This happens because of usage $context->get_child_contexts() here https://github.com/catalyst/moodle-tool_dynamic_cohorts/blob/MOODLE_404_STABLE/classes/local/tool_dynamic_cohorts/condition/user_role.php#L313C55-L313C62

@dmitriim dmitriim added the bug Something isn't working label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant