CI Checks

Author: bwalkerl

classes/check/dnsmx.php

@@ -79,7 +79,9 @@ public function get_result() : result {
             $status = result::ERROR;
             $summary = "MX DNS record missing";
         } else {
-            $allmxdomains = join('<br>', array_map(fn($x) => $x['target'] . ' (' . $x['pri'] . ')', $mxdomains));
+            $allmxdomains = join('<br>', array_map(function($x) {
+                return $x['target'] . ' (' . $x['pri'] . ')';
+            }, $mxdomains));
             $details .= "<p>MX record found on domain <code>$noreplydomain</code> pointing to<br><code>$allmxdomains</code></p>";
             $status = result::OK;
             $summary = "MX record points to " . $mxdomains[0]['target'];

classes/dns_util.php

@@ -98,6 +98,7 @@ public function get_subdomains($domain) {
 
     /**
      * Get spf txt record contents
+     * @param string $domain specify a different domain
      * @return string txt record
      */
     public function get_spf_record($domain = '') {
@@ -134,7 +135,7 @@ public function get_mxtoolbox_spf_url() {
      * Returns the include if matched
      *
      * The include can have a wildcard and this will return the actual matched value.
-     * @param string include domain
+     * @param string $include include domain
      * @return string matched include
      */
     public function include_present(string $include) {
@@ -163,6 +164,8 @@ public function get_dkim_selector() {
 
     /**
      * Get DKIM txt record contents
+     * @param string $selector DKIM selector
+     * @param string $domain DKIM domain
      * @return string txt record
      */
     public function get_dkim_dns_domain($selector, $domain) {
@@ -171,6 +174,7 @@ public function get_dkim_dns_domain($selector, $domain) {
 
     /**
      * Get DKIM txt record contents
+     * @param string $selector DKIM selector
      * @return string txt record
      */
     public function get_dkim_record($selector) {
@@ -187,7 +191,7 @@ public function get_dkim_record($selector) {
 
     /**
      * Get DKIM txt record contents
-     * @return string txt record
+     * @return array txt record
      */
     public function get_dmarc_dns_record() {
         $domain = $this->get_noreply_domain();
@@ -215,13 +219,14 @@ public function get_dmarc_dns_record() {
 
     /**
      * Get MX record contents
-     * @return string txt record
+     * @param string $domain domain to check
+     * @return array txt record
      */
     public function get_mx_record($domain) {
 
         $records = @dns_get_record($domain, DNS_MX);
         if (empty($records)) {
-            return;
+            return [];
         }
         usort($records, function($a, $b) {
             if ($a['pri'] == $b['pri']) {
@@ -234,6 +239,8 @@ public function get_mx_record($domain) {
 
     /**
      * Get matching record contents
+     * @param string $domain domain to check
+     * @param string $match search for specific match
      * @return string txt record
      */
     public function get_matching_dns_record($domain, $match) {