Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the -1 docs / handling in core #93

Open
brendanheywood opened this issue Dec 3, 2024 · 1 comment
Open

Improve the -1 docs / handling in core #93

brendanheywood opened this issue Dec 3, 2024 · 1 comment

Comments

@brendanheywood
Copy link
Contributor

Either:

  1. Have a magic constant so its it's -1 then then don't show the ratio on the page
    OR
  2. we fix core so this value can be 0 and it still works
@bwalkerl
Copy link
Contributor

bwalkerl commented Dec 4, 2024

I've included the change to fix the core setting as part of MDL-73798 - logically it doesn't make sense to use the default bounce ratio if you've explicitly set something.

There's still room to improve the docs to mention the expectation so I'll leave this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants