make test data provider methods static

Author: Sasha Anastasi

factor/email/tests/factor_test.php

@@ -29,7 +29,7 @@ class email_factor_test extends \core_phpunit\testcase {
      * Provides to test_generate_email_ip_address_location test.
      * @return array
      */
-    public function generate_email_ip_address_location_provider(): array {
+    public static function generate_email_ip_address_location_provider(): array {
         return [
             'real ip v4' => [
                 // Note - this is the same IP address used by core_iplookup_geoplugin_testcase.

factor/token/tests/factor_test.php

@@ -261,7 +261,7 @@ public function test_calculate_expiry_time_for_overnight_expiry_with_an_hour_exp
      * Increments by 30 minutes to cover half hour and hour cases.
      * Starting timestamp: 2022-01-15 07:30:00 Australia/Melbourne time.
      */
-    public function timestamp_provider() {
+    public static function timestamp_provider() {
         $starttimestamp = 1642192200;
         foreach (range(0, 23) as $i) {
             $timestamps[] = [$starttimestamp + ($i * HOURSECS)];