fix: dns service ips are automatically inflected by kamaji (#162)

prometherion · web-flow · commit 0278ce243251 · 2025-01-20T11:56:39.000+01:00
* fix(api): dns service ips are automatically inflected by kamaji

Signed-off-by: Dario Tranchitella &lt;dario@tranchitella.eu&gt;

* chore(manifest): dns service ips are automatically inflected by kamaji

Signed-off-by: Dario Tranchitella &lt;dario@tranchitella.eu&gt;

* chore(release): dns service ips are automatically inflected by kamaji

Signed-off-by: Dario Tranchitella &lt;dario@tranchitella.eu&gt;

---------

Signed-off-by: Dario Tranchitella &lt;dario@tranchitella.eu&gt;
diff --git a/api/v1alpha1/kamajicontrolplane_types.go b/api/v1alpha1/kamajicontrolplane_types.go
@@ -69,8 +69,8 @@ type AddonsSpec struct {
 
 type CoreDNSAddonSpec struct {
 	*kamajiv1alpha1.AddonSpec `json:",inline"`
-	// +kubebuilder:default={"10.96.0.10"}
-	// +kubebuilder:validation:MinItems=1
+	// DNSServiceIPs contains the CoreDNS Service IPs.
+	// When set to an empty slice, Kamaji will automatically inflect it from the Service CIDR.
 	DNSServiceIPs []string `json:"dnsServiceIPs,omitempty"`
 }
 
diff --git a/config/control-plane-components.yaml b/config/control-plane-components.yaml
@@ -86,11 +86,11 @@ spec:
                       The registry and the tag are configurable, the image is hard-coded to `coredns`.
                     properties:
                       dnsServiceIPs:
-                        default:
-                        - 10.96.0.10
+                        description: |-
+                          DNSServiceIPs contains the CoreDNS Service IPs.
+                          When set to an empty slice, Kamaji will automatically inflect it from the Service CIDR.
                         items:
                           type: string
-                        minItems: 1
                         type: array
                       imageRepository:
                         description: |-
@@ -6746,11 +6746,11 @@ spec:
                               The registry and the tag are configurable, the image is hard-coded to `coredns`.
                             properties:
                               dnsServiceIPs:
-                                default:
-                                - 10.96.0.10
+                                description: |-
+                                  DNSServiceIPs contains the CoreDNS Service IPs.
+                                  When set to an empty slice, Kamaji will automatically inflect it from the Service CIDR.
                                 items:
                                   type: string
-                                minItems: 1
                                 type: array
                               imageRepository:
                                 description: |-
diff --git a/config/crd/bases/controlplane.cluster.x-k8s.io_kamajicontrolplanes.yaml b/config/crd/bases/controlplane.cluster.x-k8s.io_kamajicontrolplanes.yaml
@@ -72,11 +72,11 @@ spec:
                       The registry and the tag are configurable, the image is hard-coded to `coredns`.
                     properties:
                       dnsServiceIPs:
-                        default:
-                        - 10.96.0.10
+                        description: |-
+                          DNSServiceIPs contains the CoreDNS Service IPs.
+                          When set to an empty slice, Kamaji will automatically inflect it from the Service CIDR.
                         items:
                           type: string
-                        minItems: 1
                         type: array
                       imageRepository:
                         description: |-
diff --git a/config/crd/bases/controlplane.cluster.x-k8s.io_kamajicontrolplanetemplates.yaml b/config/crd/bases/controlplane.cluster.x-k8s.io_kamajicontrolplanetemplates.yaml
@@ -86,11 +86,11 @@ spec:
                               The registry and the tag are configurable, the image is hard-coded to `coredns`.
                             properties:
                               dnsServiceIPs:
-                                default:
-                                - 10.96.0.10
+                                description: |-
+                                  DNSServiceIPs contains the CoreDNS Service IPs.
+                                  When set to an empty slice, Kamaji will automatically inflect it from the Service CIDR.
                                 items:
                                   type: string
-                                minItems: 1
                                 type: array
                               imageRepository:
                                 description: |-

Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,8 @@ type AddonsSpec struct {`
`69`	`69`
`70`	`70`	`type CoreDNSAddonSpec struct {`
`71`	`71`	*kamajiv1alpha1.AddonSpec `json:",inline"`
`72`		`- // +kubebuilder:default={"10.96.0.10"}`
`73`		`- // +kubebuilder:validation:MinItems=1`
	`72`	`+ // DNSServiceIPs contains the CoreDNS Service IPs.`
	`73`	`+ // When set to an empty slice, Kamaji will automatically inflect it from the Service CIDR.`
`74`	`74`	DNSServiceIPs []string `json:"dnsServiceIPs,omitempty"`
`75`	`75`	`}`
`76`	`76`