Skip to content

Commit 82a76bd

Browse files
authoredJan 20, 2025··
fix: minor styling and ci debugging (#164)
* style(go): fixing gci Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix(ci): enabling debug and removing constraints on kamaji Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
1 parent ee29426 commit 82a76bd

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed
 

‎.github/workflows/e2e.yaml

+4-2
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,13 @@ jobs:
8686
--namespace cert-manager \
8787
--create-namespace \
8888
--version v1.11.0 \
89-
--set installCRDs=true
89+
--set installCRDs=true \
90+
--debug
9091
9192
helm repo add clastix https://clastix.github.io/charts
9293
helm repo update
93-
helm install kamaji clastix/kamaji -n kamaji-system --create-namespace
94+
helm install kamaji clastix/kamaji -n kamaji-system --create-namespace --debug \
95+
--set 'resources=null' --timeout=10m
9496
9597
- name: "Setup clusterctl config"
9698
run: |

‎controllers/kamajicontrolplane_controller_externalreference.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ var (
3131

3232
//nolint:cyclop
3333
func (r *KamajiControlPlaneReconciler) extractRemoteClient(ctx context.Context, kcp v1alpha1.KamajiControlPlane) (client.Client, error) { //nolint:ireturn
34-
if !r.FeatureGates.Enabled(features.ExternalClusterReference) {
34+
if !r.FeatureGates.Enabled(features.ExternalClusterReference) {
3535
return nil, ErrExternalClusterReferenceNotEnabled
3636
}
3737

38-
if r.FeatureGates.Enabled(features.ExternalClusterReference) &&
38+
if r.FeatureGates.Enabled(features.ExternalClusterReference) &&
3939
!r.FeatureGates.Enabled(features.ExternalClusterReferenceCrossNamespace) &&
4040
kcp.Spec.Deployment.ExternalClusterReference.KubeconfigSecretNamespace != "" &&
4141
kcp.Spec.Deployment.ExternalClusterReference.KubeconfigSecretNamespace != kcp.Namespace {

0 commit comments

Comments
 (0)
Please sign in to comment.