From 55f6d55fc88b1c96076022334f9a6f3b74d3b2d2 Mon Sep 17 00:00:00 2001 From: Pandry <17499836+Pandry@users.noreply.github.com> Date: Sun, 2 Mar 2025 17:31:04 +0100 Subject: [PATCH] feat: removes LoadBalancerIP field from service spec Addresses #688, this commit removes the deprecated `spec.loadBalancerIP`. With the property being set in the service, the AWS cloud controller complained and caused issues. --- internal/resources/k8s_service_resource.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/resources/k8s_service_resource.go b/internal/resources/k8s_service_resource.go index 07e2f97e..7e7f11f3 100644 --- a/internal/resources/k8s_service_resource.go +++ b/internal/resources/k8s_service_resource.go @@ -106,9 +106,6 @@ func (r *KubernetesServiceResource) mutate(ctx context.Context, tenantControlPla if len(tenantControlPlane.Spec.NetworkProfile.LoadBalancerSourceRanges) > 0 { r.resource.Spec.LoadBalancerSourceRanges = tenantControlPlane.Spec.NetworkProfile.LoadBalancerSourceRanges } - if len(address) > 0 { - r.resource.Spec.LoadBalancerIP = address - } case kamajiv1alpha1.ServiceTypeNodePort: r.resource.Spec.Type = corev1.ServiceTypeNodePort r.resource.Spec.Ports[0].NodePort = tenantControlPlane.Spec.NetworkProfile.Port