fix: add translations for sign in error [#143] (#145)

* fix: add translations for sign in error [#143]

* fix: add missing userattribute localizations [#143]

Author: shinyford

packages/clerk_auth/lib/src/clerk_auth/auth.dart

@@ -337,10 +337,11 @@ class Auth {
 
       // No matching sign-in sequence, reset loading state
       default:
+        final status = signIn?.status ?? Status.unknown;
         addError(AuthError(
           code: AuthErrorCode.signInError,
           message: 'Unsupported sign in attempt: {arg}',
-          argument: signIn?.status.toString() ?? '',
+          argument: status.name,
         ));
     }
 

packages/clerk_auth/lib/src/models/status.dart

@@ -16,6 +16,9 @@ class Status {
   /// fromJson factory for JsonSerializable
   factory Status.fromJson(String name) => Status(name: name);
 
+  /// unknown
+  static const unknown = Status._('unknown');
+
   /// abandoned
   static const abandoned = Status._('abandoned');
 
@@ -53,6 +56,7 @@ class Status {
   static const failed = Status._('failed');
 
   static final _values = <String, Status>{
+    unknown.name: unknown,
     abandoned.name: abandoned,
     active.name: active,
     missingRequirements.name: missingRequirements,

packages/clerk_flutter/l10n/en.arb

@@ -38,6 +38,8 @@
   "alreadyHaveAnAccount": "Already have an account?",
   "anUppercaseLetter": "an UPPERCASE letter",
   "and": "and",
+  "authenticatorApp": "authenticator app",
+  "backupCode": "backup code",
   "cancel": "Cancel",
   "clickOnTheLinkThatSBeenSentToAndThenCheckBackHere": "Click on the link that‘s been sent to {identifier} and then check back here",
   "@clickOnTheLinkThatSBeenSentToAndThenCheckBackHere": {
@@ -73,6 +75,7 @@
   "enterTheCodeSentToYou": "Enter the code sent to you",
   "expired": "EXPIRED",
   "failed": "FAILED",
+  "firstName": "first name",
   "invalidEmailAddress": "Invalid email address: {address}",
   "@invalidEmailAddress": {
     "placeholders": {
@@ -97,6 +100,7 @@
       }
     }
   },
+  "lastName": "last name",
   "loading": "Loading…",
   "logo": "Logo",
   "missingRequirements": "MISSING REQUIREMENTS",
@@ -156,8 +160,10 @@
   "ok": "OK",
   "optional": "(optional)",
   "or": "or",
+  "passkey": "passkey",
   "password": "Password",
   "passwordAndPasswordConfirmationMustMatch": "Password and password confirmation must match",
+  "passwordConfirmation": "password confirmation",
   "passwordMatchError": "Password and password confirmation must match",
   "passwordMustBeSupplied": "A password must be supplied",
   "passwordRequires": "Password requires:",
@@ -174,6 +180,14 @@
   "signInByClickingALinkSentToYouByEmail": "Sign in by clicking a link sent to you by email",
   "signInByEnteringACodeSentToYouByEmail": "Sign in by entering a code sent to you by email",
   "signInByEnteringACodeSentToYouByTextMessage": "Sign in by entering a code sent to you by text message",
+  "signInError": "Unsupported sign in attempt: {arg}",
+  "@signInError": {
+    "placeholders": {
+      "arg": {
+        "type": "String"
+      }
+    }
+  },
   "signInTo": "Sign in to {name}",
   "@signInTo": {
     "placeholders": {
@@ -210,6 +224,7 @@
   "verified": "VERIFIED",
   "verifyYourEmailAddress": "Verify your email address",
   "verifyYourPhoneNumber": "Verify your phone number",
+  "web3Wallet": "web3 wallet",
   "welcomeBackPleaseSignInToContinue": "Welcome back! Please sign in to continue",
   "welcomePleaseFillInTheDetailsToGetStarted": "Welcome! Please fill in the details to get started",
   "youNeedToAdd": "You need to add:"

packages/clerk_flutter/lib/src/generated/clerk_sdk_localizations.dart

@@ -178,6 +178,18 @@ abstract class ClerkSdkLocalizations {
   /// **'and'**
   String get and;
 
+  /// No description provided for @authenticatorApp.
+  ///
+  /// In en, this message translates to:
+  /// **'authenticator app'**
+  String get authenticatorApp;
+
+  /// No description provided for @backupCode.
+  ///
+  /// In en, this message translates to:
+  /// **'backup code'**
+  String get backupCode;
+
   /// No description provided for @cancel.
   ///
   /// In en, this message translates to:
@@ -262,6 +274,12 @@ abstract class ClerkSdkLocalizations {
   /// **'FAILED'**
   String get failed;
 
+  /// No description provided for @firstName.
+  ///
+  /// In en, this message translates to:
+  /// **'first name'**
+  String get firstName;
+
   /// No description provided for @invalidEmailAddress.
   ///
   /// In en, this message translates to:
@@ -280,6 +298,12 @@ abstract class ClerkSdkLocalizations {
   /// **'JWT poorly formatted: {arg}'**
   String jwtPoorlyFormatted(String arg);
 
+  /// No description provided for @lastName.
+  ///
+  /// In en, this message translates to:
+  /// **'last name'**
+  String get lastName;
+
   /// No description provided for @loading.
   ///
   /// In en, this message translates to:
@@ -382,6 +406,12 @@ abstract class ClerkSdkLocalizations {
   /// **'or'**
   String get or;
 
+  /// No description provided for @passkey.
+  ///
+  /// In en, this message translates to:
+  /// **'passkey'**
+  String get passkey;
+
   /// No description provided for @password.
   ///
   /// In en, this message translates to:
@@ -394,6 +424,12 @@ abstract class ClerkSdkLocalizations {
   /// **'Password and password confirmation must match'**
   String get passwordAndPasswordConfirmationMustMatch;
 
+  /// No description provided for @passwordConfirmation.
+  ///
+  /// In en, this message translates to:
+  /// **'password confirmation'**
+  String get passwordConfirmation;
+
   /// No description provided for @passwordMatchError.
   ///
   /// In en, this message translates to:
@@ -490,6 +526,12 @@ abstract class ClerkSdkLocalizations {
   /// **'Sign in by entering a code sent to you by text message'**
   String get signInByEnteringACodeSentToYouByTextMessage;
 
+  /// No description provided for @signInError.
+  ///
+  /// In en, this message translates to:
+  /// **'Unsupported sign in attempt: {arg}'**
+  String signInError(String arg);
+
   /// No description provided for @signInTo.
   ///
   /// In en, this message translates to:
@@ -580,6 +622,12 @@ abstract class ClerkSdkLocalizations {
   /// **'Verify your phone number'**
   String get verifyYourPhoneNumber;
 
+  /// No description provided for @web3Wallet.
+  ///
+  /// In en, this message translates to:
+  /// **'web3 wallet'**
+  String get web3Wallet;
+
   /// No description provided for @welcomeBackPleaseSignInToContinue.
   ///
   /// In en, this message translates to:

packages/clerk_flutter/lib/src/generated/clerk_sdk_localizations_en.dart

@@ -55,6 +55,12 @@ class ClerkSdkLocalizationsEn extends ClerkSdkLocalizations {
   @override
   String get and => 'and';
 
+  @override
+  String get authenticatorApp => 'authenticator app';
+
+  @override
+  String get backupCode => 'backup code';
+
   @override
   String get cancel => 'Cancel';
 
@@ -103,6 +109,9 @@ class ClerkSdkLocalizationsEn extends ClerkSdkLocalizations {
   @override
   String get failed => 'FAILED';
 
+  @override
+  String get firstName => 'first name';
+
   @override
   String invalidEmailAddress(String address) {
     return 'Invalid email address: $address';
@@ -118,6 +127,9 @@ class ClerkSdkLocalizationsEn extends ClerkSdkLocalizations {
     return 'JWT poorly formatted: $arg';
   }
 
+  @override
+  String get lastName => 'last name';
+
   @override
   String get loading => 'Loading…';
 
@@ -181,13 +193,19 @@ class ClerkSdkLocalizationsEn extends ClerkSdkLocalizations {
   @override
   String get or => 'or';
 
+  @override
+  String get passkey => 'passkey';
+
   @override
   String get password => 'Password';
 
   @override
   String get passwordAndPasswordConfirmationMustMatch =>
       'Password and password confirmation must match';
 
+  @override
+  String get passwordConfirmation => 'password confirmation';
+
   @override
   String get passwordMatchError =>
       'Password and password confirmation must match';
@@ -242,6 +260,11 @@ class ClerkSdkLocalizationsEn extends ClerkSdkLocalizations {
   String get signInByEnteringACodeSentToYouByTextMessage =>
       'Sign in by entering a code sent to you by text message';
 
+  @override
+  String signInError(String arg) {
+    return 'Unsupported sign in attempt: $arg';
+  }
+
   @override
   String signInTo(String name) {
     return 'Sign in to $name';
@@ -293,6 +316,9 @@ class ClerkSdkLocalizationsEn extends ClerkSdkLocalizations {
   @override
   String get verifyYourPhoneNumber => 'Verify your phone number';
 
+  @override
+  String get web3Wallet => 'web3 wallet';
+
   @override
   String get welcomeBackPleaseSignInToContinue =>
       'Welcome back! Please sign in to continue';

packages/clerk_flutter/lib/src/utils/localization_extensions.dart

@@ -28,6 +28,8 @@ extension ClerkAuthErrorExtension on clerk.AuthError {
         return localizations.noSuchFirstFactorStrategy(argument.toString());
       case clerk.AuthErrorCode.noSuchSecondFactorStrategy:
         return localizations.noSuchSecondFactorStrategy(argument.toString());
+      case clerk.AuthErrorCode.signInError:
+        return localizations.signInError(argument.toString());
       default:
         return toString();
     }
@@ -94,7 +96,15 @@ extension ClerkUserAttributeLocalization on clerk.UserAttribute {
       clerk.UserAttribute.emailAddress => localizations.emailAddress,
       clerk.UserAttribute.phoneNumber => localizations.phoneNumber,
       clerk.UserAttribute.username => localizations.username,
-      _ => name,
+      clerk.UserAttribute.firstName => localizations.firstName,
+      clerk.UserAttribute.lastName => localizations.lastName,
+      clerk.UserAttribute.password => localizations.password,
+      clerk.UserAttribute.passwordConfirmation =>
+        localizations.passwordConfirmation,
+      clerk.UserAttribute.web3Wallet => localizations.web3Wallet,
+      clerk.UserAttribute.authenticatorApp => localizations.authenticatorApp,
+      clerk.UserAttribute.backupCode => localizations.backupCode,
+      clerk.UserAttribute.passkey => localizations.passkey,
     };
   }
 }