fix php deprecated functionality for PHP 8.x

Author: arielien

Command/DownloadImages.php

@@ -101,7 +101,7 @@ protected function configure()
      * @param InputInterface  $input
      * @param OutputInterface $output
      *
-     * @return void
+     * @return init
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
@@ -126,6 +126,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         } catch (\Exception $e) {
             $output->writeln($e->getMessage());
+            return 0;
         }
     }
 

Command/ProductGalleryApiQueueProcess.php

@@ -20,6 +20,11 @@ class ProductGalleryApiQueueProcess extends Command
      */
     private $appState;
 
+    /**
+     * @var $job
+     */
+    protected $job;
+
     /**
      * @method __construct
      * @param  ObjectManagerInterface $objectManager

Command/ResetAll.php

@@ -75,7 +75,7 @@ protected function configure()
      * @param InputInterface  $input
      * @param OutputInterface $output
      *
-     * @return void
+     * @return int
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
@@ -86,25 +86,26 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $helper = $this->getHelper('question');
         if (!$this->confirmActionStart($input, $output, $helper)) {
-            return;
+            return 0;
         }
 
         $adminUser = $this->getAdminUser($this->readAdminName($input, $output, $helper));
         if (!$adminUser->getId()) {
             $output->writeln(self::ADMIN_USER_NOT_FOUND);
-            return;
+            return 0;
         }
 
         $adminPassword = $this->readAdminPassword($input, $output, $helper);
         if (!$this->authenticate($adminUser, $adminPassword)) {
             $output->writeln(self::ADMIN_PASSWORD_INCORRECT);
-            return;
+            return 0;
         }
 
         $this->resetHelper->resetModule();
 
         $output->writeln(self::COMPLETE_MESSAGE1);
         $output->writeln(self::COMPLETE_MESSAGE2);
+        return 1;
     }
 
     /**

Command/StopMigration.php

@@ -47,7 +47,7 @@ protected function configure()
      * @param InputInterface  $input
      * @param OutputInterface $output
      *
-     * @return void
+     * @return int
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {

Command/UploadImages.php

@@ -89,7 +89,7 @@ protected function configure()
      * @param InputInterface  $input
      * @param OutputInterface $output
      *
-     * @return void
+     * @return int
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
@@ -108,6 +108,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             return 1;
         } catch (\Exception $e) {
             $output->writeln($e->getMessage());
+            return 0;
         }
     }
 }

Cron/ProductGalleryApiQueue.php

@@ -79,6 +79,7 @@ public function __construct(
 
     public function execute()
     {
+
         if ($this->configuration->isEnabled() && $this->configuration->isEnabledProductgalleryApiQueue()) {
             try {
                 $queuedItems = $this->productGalleryApiQueueFactory->create()->getCollection()
@@ -143,7 +144,7 @@ public function execute()
             }
         }
 
-        return $this;
+        return 1;
     }
 
     /**