Skip to content

Commit c3f309c

Browse files
authored
Quick Touch Up to Tools Page (#760)
* open links in new tab * add first name to Tools page * add typescript to Card component * increase spacing around progress bar
1 parent 5ca6298 commit c3f309c

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

src/components/Tools/Card.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
</div>
2020
</template>
2121

22-
<script>
22+
<script lang="ts">
2323
import { defineComponent } from 'vue';
2424
2525
export default defineComponent({

src/components/Tools/ProgressTracker.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ export default defineComponent({
160160
justify-content: center;
161161
flex-grow: 1;
162162
margin-bottom: 0.25rem;
163-
min-width: 200px;
163+
min-width: 220px;
164164
}
165165
166166
&-bar {

src/components/Tools/UsefulLinks.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<template>
22
<div class="links">
33
<div v-for="{ title, link } in list" :key="title" class="links-group">
4-
<a class="links-link" :href="link">
4+
<a class="links-link" :href="link" target="_blank" rel="noopener noreferrer">
55
{{ title }}
66
<img class="links-link-icon" src="@/assets/images/link-gray.svg" alt="external link" />
77
</a>

src/containers/Tools.vue

+11-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div class="toolsContainer">
33
<div class="toolsContainer-header">
44
<div class="toolsContainer-title">
5-
<span>Hi Courseplanner!</span>
5+
<span>Hi, {{ userInfo.firstName }}!</span>
66
</div>
77
<div class="toolsContainer-subtitle">
88
<span>Here are some resources to help you plan.</span>
@@ -27,16 +27,23 @@
2727
</div>
2828
</template>
2929

30-
<script>
30+
<script lang="ts">
31+
import { defineComponent } from 'vue';
3132
import Card from '@/components/Tools/Card.vue';
3233
import AdvisorCard from '@/components/Tools/AdvisorCard.vue';
3334
import UsefulLinks from '@/components/Tools/UsefulLinks.vue';
3435
import ProgressTracker from '@/components/Tools/ProgressTracker.vue';
3536
import ExportCard from '@/components/Tools/ExportCard.vue';
37+
import store from '@/store';
3638
37-
export default {
39+
export default defineComponent({
3840
components: { ProgressTracker, ExportCard, UsefulLinks, AdvisorCard, Card },
39-
};
41+
computed: {
42+
userInfo(): FirestoreUserName {
43+
return store.state.userName;
44+
},
45+
},
46+
});
4047
</script>
4148

4249
<style scoped lang="scss">

0 commit comments

Comments
 (0)