Skip to content

Commit 2327655

Browse files
committed
updates per review
1 parent d202152 commit 2327655

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

docs/how/updating-datahub.md

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
3636
### Known Issues
3737

3838
- #12601: Jetty 12 introduces a stricter handling of url encoding. We are currently applying a workaround to prevent a regression, while technically breaking the official specifications.
39+
- #12714: API Tracing requires at least one mutation of the aspect being updated using this version of DataHub.
3940

4041
### Potential Downtime
4142

metadata-ingestion/src/datahub/emitter/rest_emitter.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ class RestSinkEndpoint(ConfigEnum):
113113
)
114114

115115

116+
# Supported with v1.0
116117
DEFAULT_REST_TRACE_MODE = pydantic.parse_obj_as(
117118
RestTraceMode,
118119
os.getenv("DATAHUB_REST_TRACE_MODE", RestTraceMode.DISABLED),
@@ -456,7 +457,7 @@ def emit_mcp(
456457
response = self._emit_generic(url, payload)
457458

458459
if self._should_trace(async_flag, trace_flag):
459-
trace_data = extract_trace_data_from_mcps(response, [mcp])
460+
trace_data = extract_trace_data_from_mcps(response, [mcp]) if response else None
460461

461462
if trace_data:
462463
self._await_status(

0 commit comments

Comments
 (0)