Skip to content

Commit 256e488

Browse files
feat(searchBarAutocomplete): add feature flag for search bar's autocomplete redesign (#12690)
Co-authored-by: Victor Tarasevich <[email protected]>
1 parent 6998167 commit 256e488

File tree

6 files changed

+11
-0
lines changed

6 files changed

+11
-0
lines changed

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java

+2
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,8 @@ public CompletableFuture<AppConfig> get(final DataFetchingEnvironment environmen
204204
.setShowNavBarRedesign(_featureFlags.isShowNavBarRedesign())
205205
.setShowAutoCompleteResults(_featureFlags.isShowAutoCompleteResults())
206206
.setEntityVersioningEnabled(_featureFlags.isEntityVersioning())
207+
.setShowSearchBarAutocompleteRedesign(
208+
_featureFlags.isShowSearchBarAutocompleteRedesign())
207209
.build();
208210

209211
appConfig.setFeatureFlags(featureFlagsConfig);

datahub-graphql-core/src/main/resources/app.graphql

+5
Original file line numberDiff line numberDiff line change
@@ -593,6 +593,11 @@ type FeatureFlagsConfig {
593593
If turned on, exposes the versioning feature by allowing users to link entities in the UI.
594594
"""
595595
entityVersioningEnabled: Boolean!
596+
597+
"""
598+
If turned on, show the redesigned search bar's autocomplete
599+
"""
600+
showSearchBarAutocompleteRedesign: Boolean!
596601
}
597602

598603
"""

datahub-web-react/src/appConfigContext.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ export const DEFAULT_APP_CONFIG = {
6767
showNavBarRedesign: false,
6868
showAutoCompleteResults: false,
6969
entityVersioningEnabled: false,
70+
showSearchBarAutocompleteRedesign: false,
7071
},
7172
chromeExtensionConfig: {
7273
enabled: false,

datahub-web-react/src/graphql/app.graphql

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ query appConfig {
8282
showNavBarRedesign
8383
showAutoCompleteResults
8484
entityVersioningEnabled
85+
showSearchBarAutocompleteRedesign
8586
}
8687
chromeExtensionConfig {
8788
enabled

metadata-service/configuration/src/main/java/com/linkedin/datahub/graphql/featureflags/FeatureFlags.java

+1
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,5 @@ public class FeatureFlags {
3636
private boolean showAutoCompleteResults = false;
3737
private boolean dataProcessInstanceEntityEnabled = true;
3838
private boolean entityVersioning = false;
39+
private boolean showSearchBarAutocompleteRedesign = false;
3940
}

metadata-service/configuration/src/main/resources/application.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,7 @@ featureFlags:
503503
showNavBarRedesign: ${SHOW_NAV_BAR_REDESIGN:true} # If turned on, show the newly designed nav bar in the V2 experience
504504
showAutoCompleteResults: ${SHOW_AUTO_COMPLETE_RESULTS:true} # If turned on, show the auto complete results in the search bar
505505
entityVersioning: ${ENTITY_VERSIONING_ENABLED:false} # Enables entity versioning APIs, validators, and side effects
506+
showSearchBarAutocompleteRedesign: ${SHOW_SEARCH_BAR_AUTOCOMPLETE_REDESIGN:false} # If turned on, show the redesigned search bar's autocomplete
506507

507508
entityChangeEvents:
508509
enabled: ${ENABLE_ENTITY_CHANGE_EVENTS_HOOK:true}

0 commit comments

Comments
 (0)