Skip to content

Commit 2688bf3

Browse files
BlizeMatthias Mantsch
and
Matthias Mantsch
authored
Add variable to show full title in lineage by default (#12078)
Co-authored-by: Matthias Mantsch <[email protected]>
1 parent 679d4cb commit 2688bf3

File tree

6 files changed

+16
-1
lines changed

6 files changed

+16
-1
lines changed

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java

+1
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ public CompletableFuture<AppConfig> get(final DataFetchingEnvironment environmen
140140
visualConfig.setAppTitle(_visualConfiguration.getAppTitle());
141141
}
142142
visualConfig.setHideGlossary(_visualConfiguration.isHideGlossary());
143+
visualConfig.setShowFullTitleInLineage(_visualConfiguration.isShowFullTitleInLineage());
143144
}
144145
if (_visualConfiguration != null && _visualConfiguration.getQueriesTab() != null) {
145146
QueriesTabConfig queriesTabConfig = new QueriesTabConfig();

datahub-graphql-core/src/main/resources/app.graphql

+5
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,11 @@ type VisualConfig {
276276
Configuration for search results
277277
"""
278278
searchResult: SearchResultsVisualConfig
279+
280+
"""
281+
Show full title in lineage view by default
282+
"""
283+
showFullTitleInLineage: Boolean
279284
}
280285

281286
"""

datahub-web-react/src/app/lineage/LineageVizInsideZoom.tsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { SchemaField, SchemaFieldRef } from '../../types.generated';
1010
import { useIsShowColumnsMode } from './utils/useIsShowColumnsMode';
1111
import { LineageVizControls } from './controls/LineageVizControls';
1212
import LineageVizRootSvg from './LineageVizRootSvg';
13+
import { useAppConfig } from '../useAppConfig';
1314

1415
const ControlsDiv = styled.div`
1516
display: flex;
@@ -65,12 +66,15 @@ export default function LineageVizInsideZoom({
6566
fineGrainedMap,
6667
refetchCenterNode,
6768
}: Props) {
69+
const appConfig = useAppConfig();
70+
const showFullTitle = appConfig.config.visualConfig.showFullTitleInLineage;
71+
6872
const [collapsedColumnsNodes, setCollapsedColumnsNodes] = useState<Record<string, boolean>>({});
6973
const [selectedField, setSelectedField] = useState<SchemaFieldRef | null>(null);
7074
const [highlightedEdges, setHighlightedEdges] = useState<ColumnEdge[]>([]);
7175
const [visibleColumnsByUrn, setVisibleColumnsByUrn] = useState<Record<string, Set<string>>>({});
7276
const [columnsByUrn, setColumnsByUrn] = useState<Record<string, SchemaField[]>>({});
73-
const [showExpandedTitles, setShowExpandedTitles] = useState(false);
77+
const [showExpandedTitles, setShowExpandedTitles] = useState(showFullTitle ?? false);
7478
const showColumns = useIsShowColumnsMode();
7579

7680
useEffect(() => {

datahub-web-react/src/graphql/app.graphql

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ query appConfig {
3737
visualConfig {
3838
logoUrl
3939
faviconUrl
40+
showFullTitleInLineage
4041
queriesTab {
4142
queriesTabResultSize
4243
}

metadata-service/configuration/src/main/java/com/linkedin/metadata/config/VisualConfiguration.java

+3
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,7 @@ public class VisualConfiguration {
2525

2626
/** Search result related configurations */
2727
public SearchResultVisualConfig searchResult;
28+
29+
/** Boolean flag enabled shows the full title of an entity in lineage view by default */
30+
public boolean showFullTitleInLineage;
2831
}

metadata-service/configuration/src/main/resources/application.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ visualConfig:
154154
faviconUrl: ${REACT_APP_FAVICON_URL:/assets/icons/favicon.ico}
155155
appTitle: ${REACT_APP_TITLE:}
156156
hideGlossary: ${REACT_APP_HIDE_GLOSSARY:false}
157+
showFullTitleInLineage: ${REACT_APP_SHOW_FULL_TITLE_IN_LINEAGE:false}
157158
entityProfile:
158159
# we only support default tab for domains right now. In order to implement for other entities, update React code
159160
domainDefaultTab: ${DOMAIN_DEFAULT_TAB:} # set to DOCUMENTATION_TAB to show documentation tab first

0 commit comments

Comments
 (0)