Skip to content

Commit 2df95ac

Browse files
committed
fix(ingest/powerbi): Lint fix
1 parent a301f79 commit 2df95ac

File tree

3 files changed

+17
-22
lines changed

3 files changed

+17
-22
lines changed

metadata-ingestion/src/datahub/ingestion/source/powerbi/config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ class PowerBiDashboardSourceConfig(
304304
workspace_name_pattern: AllowDenyPattern = pydantic.Field(
305305
default=AllowDenyPattern.allow_all(),
306306
description="Regex patterns to filter PowerBI workspaces in ingestion."
307-
" Note: This field works in conjunction with 'workspace_type_filter' and both must be considered when filtering workspaces.",
307+
" Note: This field works in conjunction with 'workspace_type_filter' and both must be considered when filtering workspaces.",
308308
)
309309

310310
# Dataset type mapping PowerBI support many type of data-sources. Here user needs to define what type of PowerBI

metadata-ingestion/src/datahub/ingestion/source/powerbi/m_query/pattern_handler.py

+13-19
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import logging
22
from abc import ABC, abstractmethod
33
from enum import Enum
4-
from typing import Dict, List, Optional, Tuple, Type, cast, Any
4+
from typing import Dict, List, Optional, Tuple, Type, cast
55

66
from lark import Tree
77

@@ -30,13 +30,13 @@
3030
ReferencedTable,
3131
)
3232
from datahub.ingestion.source.powerbi.rest_api_wrapper.data_classes import Table
33+
from datahub.metadata.schema_classes import SchemaFieldDataTypeClass
3334
from datahub.sql_parsing.sqlglot_lineage import (
34-
SqlParsingResult,
3535
ColumnLineageInfo,
36+
ColumnRef,
3637
DownstreamColumnRef,
37-
ColumnRef
38+
SqlParsingResult,
3839
)
39-
from datahub.metadata.schema_classes import SchemaFieldDataTypeClass
4040

4141
logger = logging.getLogger(__name__)
4242

@@ -268,17 +268,15 @@ def parse_custom_sql(
268268
),
269269
)
270270

271-
def create_table_column_lineage(
272-
self, urn: str
273-
) -> List[ColumnLineageInfo]:
271+
def create_table_column_lineage(self, urn: str) -> List[ColumnLineageInfo]:
274272
column_lineage = []
275273

276274
for column in self.table.columns:
277275
downstream = DownstreamColumnRef(
278276
table=self.table.name,
279277
column=column.name,
280278
column_type=SchemaFieldDataTypeClass(type=column.datahubDataType),
281-
native_column_type=column.dataType or "UNKNOWN"
279+
native_column_type=column.dataType or "UNKNOWN",
282280
)
283281

284282
upstreams = [
@@ -289,8 +287,7 @@ def create_table_column_lineage(
289287
]
290288

291289
column_lineage_info = ColumnLineageInfo(
292-
downstream=downstream,
293-
upstreams=upstreams
290+
downstream=downstream, upstreams=upstreams
294291
)
295292

296293
column_lineage.append(column_lineage_info)
@@ -343,7 +340,7 @@ def create_lineage(
343340
urn=urn,
344341
)
345342
],
346-
column_lineage=column_lineage
343+
column_lineage=column_lineage,
347344
)
348345

349346

@@ -410,7 +407,7 @@ def create_lineage(
410407
urn=urn,
411408
)
412409
],
413-
column_lineage=column_lineage
410+
column_lineage=column_lineage,
414411
)
415412

416413

@@ -497,7 +494,7 @@ def create_lineage(
497494
urn=urn,
498495
)
499496
],
500-
column_lineage=column_lineage
497+
column_lineage=column_lineage,
501498
)
502499

503500
return Lineage.empty()
@@ -560,7 +557,7 @@ def two_level_access_pattern(
560557
urn=urn,
561558
)
562559
],
563-
column_lineage=column_lineage
560+
column_lineage=column_lineage,
564561
)
565562

566563

@@ -724,7 +721,7 @@ def create_lineage(
724721
urn=urn,
725722
)
726723
],
727-
column_lineage=column_lineage
724+
column_lineage=column_lineage,
728725
)
729726

730727

@@ -799,10 +796,7 @@ def create_urn_using_old_parser(self, query: str, server: str) -> Lineage:
799796

800797
logger.debug(f"Generated dataplatform_tables {dataplatform_tables}")
801798

802-
return Lineage(
803-
upstreams=dataplatform_tables,
804-
column_lineage=column_lineage
805-
)
799+
return Lineage(upstreams=dataplatform_tables, column_lineage=column_lineage)
806800

807801
def get_db_name(self, data_access_tokens: List[str]) -> Optional[str]:
808802
if (

metadata-ingestion/src/datahub/ingestion/source/powerbi/powerbi.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -1306,8 +1306,9 @@ def get_allowed_workspaces(self) -> List[powerbi_data_classes.Workspace]:
13061306

13071307
allowed_workspaces = []
13081308
for workspace in all_workspaces:
1309-
if (not self.source_config.workspace_id_pattern.allowed(workspace.id)
1310-
or not self.source_config.workspace_name_pattern.allowed(workspace.name)):
1309+
if not self.source_config.workspace_id_pattern.allowed(
1310+
workspace.id
1311+
) or not self.source_config.workspace_name_pattern.allowed(workspace.name):
13111312
self.reporter.filtered_workspace_names.append(
13121313
f"{workspace.id} - {workspace.name}"
13131314
)

0 commit comments

Comments
 (0)