Skip to content

Commit 338afb4

Browse files
committed
update import and lint in mlflow.py
1 parent b50a148 commit 338afb4

File tree

1 file changed

+16
-10
lines changed
  • metadata-ingestion/src/datahub/ingestion/source

1 file changed

+16
-10
lines changed

metadata-ingestion/src/datahub/ingestion/source/mlflow.py

+16-10
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import time
44

55
from mlflow import MlflowClient
6-
from mlflow.entities import Run
7-
from mlflow.entities.model_registry import ModelVersion, RegisteredModel, Experiment
6+
from mlflow.entities import Run, Experiment
7+
from mlflow.entities.model_registry import ModelVersion, RegisteredModel
88
from mlflow.store.entities import PagedList
99
from pydantic.fields import Field
1010

@@ -45,7 +45,14 @@
4545
DataProcessInstanceRunResultClass,
4646
DataProcessInstanceOutputClass,
4747
)
48-
from datahub.metadata.urns import DatasetUrn, DataPlatformUrn, MlModelUrn, MlModelGroupUrn, DataProcessInstanceUrn, DataPlatformInstanceUrn
48+
from datahub.metadata.urns import (
49+
DatasetUrn,
50+
DataPlatformUrn,
51+
MlModelUrn,
52+
MlModelGroupUrn,
53+
DataProcessInstanceUrn,
54+
DataPlatformInstanceUrn,
55+
)
4956
from datahub.api.entities.dataprocess.dataprocess_instance import (
5057
DataProcessInstance,
5158
InstanceRunResult,
@@ -213,14 +220,16 @@ def _get_experiment_container_workunit(
213220
experiment_container = Container(
214221
key=ContainerKeyWithId(
215222
platform=str(DataPlatformUrn.create_from_id("mlflow")),
216-
id=experiment.name
223+
id=experiment.name,
217224
),
218225
subtype="ML Experiment",
219226
name=experiment.name,
220227
description=experiment.tags.get("mlflow.note.content"),
221228
) # TODO: this generates a urn as guid, should we change this to use experiment.id?
222229

223-
print("experiment.key.id:", experiment.key.id) # this should be same as container key as urn
230+
print(
231+
"experiment.key.id:", experiment.key.id
232+
) # this should be same as container key as urn
224233
print("experiment.key.as_urn(): ", experiment.key.as_urn())
225234

226235
workunits = [mcp.as_workunit() for mcp in experiment.generate_mcp()]
@@ -298,9 +307,7 @@ def _get_run_workunits(
298307
workunits.append(
299308
MetadataChangeProposalWrapper(
300309
entityUrn=str(data_process_instance.urn),
301-
aspect=DataProcessInstanceOutputClass(
302-
outputs=[model_version_urn]
303-
),
310+
aspect=DataProcessInstanceOutputClass(outputs=[model_version_urn]),
304311
).as_workunit()
305312
)
306313

@@ -323,7 +330,6 @@ def _get_run_workunits(
323330
) # TODO: this should be SUCCESS, SKIPPED, FAILURE, UP_FOR_RETRY
324331
duration_millis = run.info.end_time - run.info.start_time
325332

326-
327333
if run.info.end_time:
328334
workunits.append(
329335
MetadataChangeProposalWrapper(
@@ -357,7 +363,7 @@ def _get_run_workunits(
357363
created=AuditStampClass(
358364
time=created_time,
359365
actor=created_actor,
360-
)
366+
),
361367
),
362368
).as_workunit()
363369
)

0 commit comments

Comments
 (0)