Skip to content

Commit 36f746f

Browse files
test: updated golden files
1 parent 865b5ff commit 36f746f

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

metadata-ingestion/tests/integration/lookml/test_lookml.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,10 @@ def test_view_to_view_lineage_and_liquid_template(pytestconfig, tmp_path, mock_t
873873
"_is_selected": True,
874874
},
875875
"source_region": "ap-south-1",
876-
"star_award_winner_year": "public.winner_2025",
876+
"db": "test-db",
877+
}
878+
new_recipe["source"]["config"]["lookml_parameter"] = {
879+
"star_award_winner_year": "public.winner_2025"
877880
}
878881

879882
pipeline = Pipeline.create(new_recipe)

metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/star_award_winner.view.lkml

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
view: star_award_winner {
2-
sql_table_name: @{star_award_winner_year} ;;
2+
sql_table_name: ${db}.@{star_award_winner_year};;
3+
34

45
dimension: id {
56
label: "id"

metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -2853,7 +2853,7 @@
28532853
"aspect": {
28542854
"json": {
28552855
"materialized": false,
2856-
"viewLogic": "view: star_award_winner {\n sql_table_name: @{star_award_winner_year} ;;\n\n dimension: id {\n label: \"id\"\n primary_key: yes\n type: number\n sql: ${TABLE}.id ;;\n }\n\n parameter: star_award_winner_year {\n type: string\n allowed_value: {\n label: \"Star Award Winner Of 2025\"\n value: \"public.winner_2025\"\n }\n allowed_value: {\n label: \"Star Award Winner Of 2024\"\n value: \"public.winner_2024\"\n }\n }\n\n}",
2856+
"viewLogic": "view: star_award_winner {\n sql_table_name: ${db}.@{star_award_winner_year};;\n\n\n dimension: id {\n label: \"id\"\n primary_key: yes\n type: number\n sql: ${TABLE}.id ;;\n }\n\n parameter: star_award_winner_year {\n type: string\n allowed_value: {\n label: \"Star Award Winner Of 2025\"\n value: \"public.winner_2025\"\n }\n allowed_value: {\n label: \"Star Award Winner Of 2024\"\n value: \"public.winner_2024\"\n }\n }\n\n}",
28572857
"viewLanguage": "lookml"
28582858
}
28592859
},
@@ -2904,15 +2904,15 @@
29042904
"time": 1586847600000,
29052905
"actor": "urn:li:corpuser:datahub"
29062906
},
2907-
"dataset": "urn:li:dataset:(urn:li:dataPlatform:postgres,.public.winner_2025,PROD)",
2907+
"dataset": "urn:li:dataset:(urn:li:dataPlatform:postgres,test-db.public.winner_2025,PROD)",
29082908
"type": "VIEW"
29092909
}
29102910
],
29112911
"fineGrainedLineages": [
29122912
{
29132913
"upstreamType": "FIELD_SET",
29142914
"upstreams": [
2915-
"urn:li:schemaField:(urn:li:dataset:(urn:li:dataPlatform:postgres,.public.winner_2025,PROD),id)"
2915+
"urn:li:schemaField:(urn:li:dataset:(urn:li:dataPlatform:postgres,test-db.public.winner_2025,PROD),id)"
29162916
],
29172917
"downstreamType": "FIELD",
29182918
"downstreams": [

0 commit comments

Comments
 (0)