fix(powerbi): fixes direction of the dashboard-report lineage

Author: sgomezvillamor

metadata-ingestion/src/datahub/ingestion/source/powerbi/powerbi.py

@@ -666,6 +666,7 @@ def to_datahub_dashboard_mcp(
         workspace: powerbi_data_classes.Workspace,
         chart_mcps: List[MetadataChangeProposalWrapper],
         user_mcps: List[MetadataChangeProposalWrapper],
+        dashboard_edges: List[EdgeClass],
     ) -> List[MetadataChangeProposalWrapper]:
         """
         Map PowerBi dashboard to Datahub dashboard
@@ -695,6 +696,7 @@ def chart_custom_properties(dashboard: powerbi_data_classes.Dashboard) -> dict:
             lastModified=ChangeAuditStamps(),
             dashboardUrl=dashboard.webUrl,
             customProperties={**chart_custom_properties(dashboard)},
+            dashboards=dashboard_edges,
         )
 
         info_mcp = self.new_mcp(
@@ -933,7 +935,7 @@ def to_datahub_work_units(
         dashboard: powerbi_data_classes.Dashboard,
         workspace: powerbi_data_classes.Workspace,
     ) -> List[EquableMetadataWorkUnit]:
-        mcps = []
+        mcps: List[MetadataChangeProposalWrapper] = []
 
         logger.info(
             f"Converting dashboard={dashboard.displayName} to datahub dashboard"
@@ -945,9 +947,35 @@ def to_datahub_work_units(
         )
         # Convert tiles to charts
         ds_mcps, chart_mcps = self.to_datahub_chart(dashboard.tiles, workspace)
+
+        # collect all downstream reports
+        downstream_dashboards_edges = []
+        for t in dashboard.tiles:
+            if t.report_id:
+                report = workspace.reports.get(t.report_id)
+                if report is None:
+                    # a title referencing a missed report was already reported during "fill_dashboards"
+                    continue
+
+                dashboard_urn = builder.make_dashboard_urn(
+                    platform=self.__config.platform_name,
+                    platform_instance=self.__config.platform_instance,
+                    name=report.get_urn_part(),
+                )
+                edge = EdgeClass(
+                    destinationUrn=dashboard_urn,
+                    sourceUrn=None,
+                    created=None,
+                    lastModified=None,
+                    properties=None,
+                )
+                downstream_dashboards_edges.append(edge)
+
         # Lets convert dashboard to datahub dashboard
         dashboard_mcps: List[MetadataChangeProposalWrapper] = (
-            self.to_datahub_dashboard_mcp(dashboard, workspace, chart_mcps, user_mcps)
+            self.to_datahub_dashboard_mcp(
+                dashboard, workspace, chart_mcps, user_mcps, downstream_dashboards_edges
+            )
         )
 
         # Now add MCPs in sequence
@@ -1054,7 +1082,6 @@ def report_to_dashboard(
         report: powerbi_data_classes.Report,
         chart_mcps: List[MetadataChangeProposalWrapper],
         user_mcps: List[MetadataChangeProposalWrapper],
-        dashboard_edges: List[EdgeClass],
     ) -> List[MetadataChangeProposalWrapper]:
         """
         Map PowerBi report to Datahub dashboard
@@ -1076,7 +1103,6 @@ def report_to_dashboard(
             charts=chart_urn_list,
             lastModified=ChangeAuditStamps(),
             dashboardUrl=report.webUrl,
-            dashboards=dashboard_edges,
         )
 
         info_mcp = self.new_mcp(
@@ -1170,27 +1196,12 @@ def report_to_datahub_work_units(
         ds_mcps = self.to_datahub_dataset(report.dataset, workspace)
         chart_mcps = self.pages_to_chart(report.pages, workspace, ds_mcps)
 
-        # find all dashboards with a Tile referencing this report
-        downstream_dashboards_edges = []
-        for d in workspace.dashboards.values():
-            if any(t.report_id == report.id for t in d.tiles):
-                dashboard_urn = builder.make_dashboard_urn(
-                    platform=self.__config.platform_name,
-                    platform_instance=self.__config.platform_instance,
-                    name=d.get_urn_part(),
-                )
-                edge = EdgeClass(
-                    destinationUrn=dashboard_urn,
-                    sourceUrn=None,
-                    created=None,
-                    lastModified=None,
-                    properties=None,
-                )
-                downstream_dashboards_edges.append(edge)
-
         # Let's convert report to datahub dashboard
         report_mcps = self.report_to_dashboard(
-            workspace, report, chart_mcps, user_mcps, downstream_dashboards_edges
+            workspace,
+            report,
+            chart_mcps,
+            user_mcps,
         )
 
         # Now add MCPs in sequence

metadata-ingestion/tests/integration/powerbi/golden_test_container.json

@@ -1744,6 +1744,13 @@
                 "path": "/dashboardUrl",
                 "value": "https://localhost/dashboards/web/1"
             },
+            {
+                "op": "add",
+                "path": "/dashboards/urn:li:dashboard:(powerbi,reports.5b218778-e7a5-4d73-8187-f10824047715)",
+                "value": {
+                    "destinationUrn": "urn:li:dashboard:(powerbi,reports.5b218778-e7a5-4d73-8187-f10824047715)"
+                }
+            },
             {
                 "op": "add",
                 "path": "/lastModified",
@@ -2948,13 +2955,6 @@
                 "path": "/dashboardUrl",
                 "value": "https://app.powerbi.com/groups/f089354e-8366-4e18-aea3-4cb4a3a50b48/reports/5b218778-e7a5-4d73-8187-f10824047715"
             },
-            {
-                "op": "add",
-                "path": "/dashboards/urn:li:dashboard:(powerbi,dashboards.7D668CAD-7FFC-4505-9215-655BCA5BEBAE)",
-                "value": {
-                    "destinationUrn": "urn:li:dashboard:(powerbi,dashboards.7D668CAD-7FFC-4505-9215-655BCA5BEBAE)"
-                }
-            },
             {
                 "op": "add",
                 "path": "/lastModified",

metadata-ingestion/tests/integration/powerbi/golden_test_report.json

@@ -1038,6 +1038,13 @@
                 "path": "/dashboardUrl",
                 "value": "https://localhost/dashboards/web/1"
             },
+            {
+                "op": "add",
+                "path": "/dashboards/urn:li:dashboard:(powerbi,reports.5b218778-e7a5-4d73-8187-f10824047715)",
+                "value": {
+                    "destinationUrn": "urn:li:dashboard:(powerbi,reports.5b218778-e7a5-4d73-8187-f10824047715)"
+                }
+            },
             {
                 "op": "add",
                 "path": "/lastModified",
@@ -1993,13 +2000,6 @@
                 "path": "/dashboardUrl",
                 "value": "https://app.powerbi.com/groups/f089354e-8366-4e18-aea3-4cb4a3a50b48/reports/5b218778-e7a5-4d73-8187-f10824047715"
             },
-            {
-                "op": "add",
-                "path": "/dashboards/urn:li:dashboard:(powerbi,dashboards.7D668CAD-7FFC-4505-9215-655BCA5BEBAE)",
-                "value": {
-                    "destinationUrn": "urn:li:dashboard:(powerbi,dashboards.7D668CAD-7FFC-4505-9215-655BCA5BEBAE)"
-                }
-            },
             {
                 "op": "add",
                 "path": "/lastModified",