Skip to content

Commit 4c1181d

Browse files
fix(ui) Hide default filters we want to hide from impact analysis
1 parent 1068e2b commit 4c1181d

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

datahub-web-react/src/app/search/SimpleSearchFilters.tsx

+8-1
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,19 @@ import {
88
DEGREE_FILTER_NAME,
99
ENTITY_FILTER_NAME,
1010
ENTITY_INDEX_FILTER_NAME,
11+
ENTITY_SUB_TYPE_FILTER_NAME,
1112
LEGACY_ENTITY_FILTER_NAME,
13+
SCHEMA_FIELD_ALIASES_FILTER_NAME,
1214
} from './utils/constants';
1315

1416
const TOP_FILTERS = ['degree', ENTITY_FILTER_NAME, 'platform', 'tags', 'glossaryTerms', 'domains', 'owners'];
1517

16-
const FILTERS_TO_EXCLUDE = [LEGACY_ENTITY_FILTER_NAME, ENTITY_INDEX_FILTER_NAME];
18+
const FILTERS_TO_EXCLUDE = [
19+
LEGACY_ENTITY_FILTER_NAME,
20+
ENTITY_INDEX_FILTER_NAME,
21+
ENTITY_SUB_TYPE_FILTER_NAME,
22+
SCHEMA_FIELD_ALIASES_FILTER_NAME,
23+
];
1724

1825
interface Props {
1926
facets: Array<FacetMetadata>;

datahub-web-react/src/app/search/utils/constants.ts

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export const INCOMPLETE_FORMS_FILTER_NAME = 'incompleteForms';
4040
export const VERIFIED_FORMS_FILTER_NAME = 'verifiedForms';
4141
export const COMPLETED_FORMS_COMPLETED_PROMPT_IDS_FILTER_NAME = 'completedFormsCompletedPromptIds';
4242
export const INCOMPLETE_FORMS_COMPLETED_PROMPT_IDS_FILTER_NAME = 'incompleteFormsCompletedPromptIds';
43+
export const SCHEMA_FIELD_ALIASES_FILTER_NAME = 'schemaFieldAliases';
4344

4445
export const LEGACY_ENTITY_FILTER_FIELDS = [ENTITY_FILTER_NAME, LEGACY_ENTITY_FILTER_NAME];
4546

datahub-web-react/src/app/searchV2/SimpleSearchFilters.tsx

+7-1
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,16 @@ import {
1111
ENTITY_SUB_TYPE_FILTER_NAME,
1212
DEGREE_FILTER_NAME,
1313
} from './utils/constants';
14+
import { SCHEMA_FIELD_ALIASES_FILTER_NAME } from '../search/utils/constants';
1415

1516
const TOP_FILTERS = ['degree', ENTITY_FILTER_NAME, 'platform', 'tags', 'glossaryTerms', 'domains', 'owners'];
1617

17-
const FILTERS_TO_EXCLUDE = [LEGACY_ENTITY_FILTER_NAME, ENTITY_INDEX_FILTER_NAME, ENTITY_SUB_TYPE_FILTER_NAME];
18+
const FILTERS_TO_EXCLUDE = [
19+
LEGACY_ENTITY_FILTER_NAME,
20+
ENTITY_INDEX_FILTER_NAME,
21+
ENTITY_SUB_TYPE_FILTER_NAME,
22+
SCHEMA_FIELD_ALIASES_FILTER_NAME,
23+
];
1824

1925
interface Props {
2026
facets: Array<FacetMetadata>;

0 commit comments

Comments
 (0)