Skip to content

Commit 5c4d7ad

Browse files
committed
Fix tests
1 parent d3b679e commit 5c4d7ad

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_tag.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,11 @@ def create_structured_property_templates(self) -> Iterable[MetadataWorkUnit]:
8282
for tag in self.data_dictionary.get_all_tags():
8383
if not self.config.tag_pattern.allowed(tag.tag_identifier()):
8484
continue
85-
if not self.config.database_pattern.allowed(tag.database):
86-
continue
87-
if not self.config.schema_pattern.allowed(f"{tag.database}.{tag.schema}"):
88-
continue
85+
# Do we need to filter based on database and schema or is it enough if we filter based on tag pattern?
86+
# if not self.config.database_pattern.allowed(tag.database):
87+
# continue
88+
# if not self.config.schema_pattern.allowed(f"{tag.database}.{tag.schema}"):
89+
# continue
8990

9091
if self.config.extract_tags_as_structured_properties:
9192
self.report.num_structured_property_templates_created += 1

metadata-ingestion/tests/integration/snowflake/test_snowflake.py

+1
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ def test_snowflake_tags_as_structured_properties(
219219
include_column_lineage=False,
220220
include_usage_stats=False,
221221
include_operational_stats=False,
222+
structured_properties_template_cache_invalidation_interval=1,
222223
),
223224
),
224225
sink=DynamicTypedConfig(

0 commit comments

Comments
 (0)