Skip to content

Commit 643da73

Browse files
Merge branch 'master' into identify_partition_columns_hive
2 parents 0f5797c + d1d91d8 commit 643da73

File tree

6 files changed

+24
-9
lines changed

6 files changed

+24
-9
lines changed

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/search/SearchUtils.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ private SearchUtils() {}
9191
EntityType.DATA_PRODUCT,
9292
EntityType.NOTEBOOK,
9393
EntityType.BUSINESS_ATTRIBUTE,
94-
EntityType.SCHEMA_FIELD,
95-
EntityType.DATA_PLATFORM_INSTANCE);
94+
EntityType.SCHEMA_FIELD);
9695

9796
/** Entities that are part of autocomplete by default in Auto Complete Across Entities */
9897
public static final List<EntityType> AUTO_COMPLETE_ENTITY_TYPES =

datahub-web-react/src/app/entityV2/domain/DataProductsTab/DataProductResult.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { useEntityRegistryV2 } from '../../../useEntityRegistry';
77
import { PreviewType } from '../../Entity';
88
import EditDataProductModal from './EditDataProductModal';
99
import { REDESIGN_COLORS } from '../../shared/constants';
10-
import useDeleteEntity from '../../shared/EntityDropdown/useDeleteEntity';
1110

1211
const TransparentButton = styled(Button)`
1312
color: ${REDESIGN_COLORS.RED_ERROR};
@@ -62,10 +61,8 @@ export default function DataProductResult({ dataProduct, onUpdateDataProduct, se
6261
setDeletedDataProductUrns((currentUrns) => [...currentUrns, dataProduct.urn]);
6362
}
6463

65-
const { onDeleteEntity } = useDeleteEntity(dataProduct.urn, dataProduct.type, dataProduct, deleteDataProduct);
66-
6764
function onDeleteDataProduct() {
68-
onDeleteEntity();
65+
deleteDataProduct();
6966
setTimeout(() => refetch(), 3000);
7067
}
7168

datahub-web-react/src/app/entityV2/shared/EntityDropdown/UpdateDeprecationModal.tsx

+6-1
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,12 @@ export const UpdateDeprecationModal = ({ urns, resourceRefs, onClose, refetch, z
179179
</Button>
180180
)}
181181
{!replacementUrn && (
182-
<Button variant="outline" size="sm" onClick={() => setIsReplacementModalVisible(true)}>
182+
<Button
183+
variant="outline"
184+
type="button"
185+
size="sm"
186+
onClick={() => setIsReplacementModalVisible(true)}
187+
>
183188
Select Replacement
184189
</Button>
185190
)}

datahub-web-react/src/app/search/SimpleSearchFilters.tsx

+8-1
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,19 @@ import {
88
DEGREE_FILTER_NAME,
99
ENTITY_FILTER_NAME,
1010
ENTITY_INDEX_FILTER_NAME,
11+
ENTITY_SUB_TYPE_FILTER_NAME,
1112
LEGACY_ENTITY_FILTER_NAME,
13+
SCHEMA_FIELD_ALIASES_FILTER_NAME,
1214
} from './utils/constants';
1315

1416
const TOP_FILTERS = ['degree', ENTITY_FILTER_NAME, 'platform', 'tags', 'glossaryTerms', 'domains', 'owners'];
1517

16-
const FILTERS_TO_EXCLUDE = [LEGACY_ENTITY_FILTER_NAME, ENTITY_INDEX_FILTER_NAME];
18+
const FILTERS_TO_EXCLUDE = [
19+
LEGACY_ENTITY_FILTER_NAME,
20+
ENTITY_INDEX_FILTER_NAME,
21+
ENTITY_SUB_TYPE_FILTER_NAME,
22+
SCHEMA_FIELD_ALIASES_FILTER_NAME,
23+
];
1724

1825
interface Props {
1926
facets: Array<FacetMetadata>;

datahub-web-react/src/app/search/utils/constants.ts

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export const INCOMPLETE_FORMS_FILTER_NAME = 'incompleteForms';
4040
export const VERIFIED_FORMS_FILTER_NAME = 'verifiedForms';
4141
export const COMPLETED_FORMS_COMPLETED_PROMPT_IDS_FILTER_NAME = 'completedFormsCompletedPromptIds';
4242
export const INCOMPLETE_FORMS_COMPLETED_PROMPT_IDS_FILTER_NAME = 'incompleteFormsCompletedPromptIds';
43+
export const SCHEMA_FIELD_ALIASES_FILTER_NAME = 'schemaFieldAliases';
4344

4445
export const LEGACY_ENTITY_FILTER_FIELDS = [ENTITY_FILTER_NAME, LEGACY_ENTITY_FILTER_NAME];
4546

datahub-web-react/src/app/searchV2/SimpleSearchFilters.tsx

+7-1
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,16 @@ import {
1111
ENTITY_SUB_TYPE_FILTER_NAME,
1212
DEGREE_FILTER_NAME,
1313
} from './utils/constants';
14+
import { SCHEMA_FIELD_ALIASES_FILTER_NAME } from '../search/utils/constants';
1415

1516
const TOP_FILTERS = ['degree', ENTITY_FILTER_NAME, 'platform', 'tags', 'glossaryTerms', 'domains', 'owners'];
1617

17-
const FILTERS_TO_EXCLUDE = [LEGACY_ENTITY_FILTER_NAME, ENTITY_INDEX_FILTER_NAME, ENTITY_SUB_TYPE_FILTER_NAME];
18+
const FILTERS_TO_EXCLUDE = [
19+
LEGACY_ENTITY_FILTER_NAME,
20+
ENTITY_INDEX_FILTER_NAME,
21+
ENTITY_SUB_TYPE_FILTER_NAME,
22+
SCHEMA_FIELD_ALIASES_FILTER_NAME,
23+
];
1824

1925
interface Props {
2026
facets: Array<FacetMetadata>;

0 commit comments

Comments
 (0)