Skip to content

Commit 65b4dd3

Browse files
committed
feat(ui/groups): add ability to set logos for datahub groups
1 parent e4bc915 commit 65b4dd3

File tree

5 files changed

+24
-2
lines changed

5 files changed

+24
-2
lines changed

datahub-web-react/src/app/entity/group/GroupEditModal.tsx

+17
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ type PropsData = {
77
email: string | undefined;
88
slack: string | undefined;
99
urn: string | undefined;
10+
photoUrl: string | undefined;
1011
};
1112

1213
type Props = {
@@ -27,6 +28,7 @@ export default function GroupEditModal({ visible, onClose, onSave, editModalData
2728
slack: editModalData.slack,
2829
email: editModalData.email,
2930
urn: editModalData.urn,
31+
photoUrl: editModalData.photoUrl,
3032
});
3133

3234
useEffect(() => {
@@ -41,6 +43,7 @@ export default function GroupEditModal({ visible, onClose, onSave, editModalData
4143
input: {
4244
email: data.email,
4345
slack: data.slack,
46+
pictureLink: data.photoUrl,
4447
},
4548
},
4649
})
@@ -55,6 +58,7 @@ export default function GroupEditModal({ visible, onClose, onSave, editModalData
5558
email: '',
5659
slack: '',
5760
urn: '',
61+
photoUrl: '',
5862
});
5963
})
6064
.catch((e) => {
@@ -125,6 +129,19 @@ export default function GroupEditModal({ visible, onClose, onSave, editModalData
125129
onChange={(event) => setData({ ...data, slack: event.target.value })}
126130
/>
127131
</Form.Item>
132+
133+
<Form.Item
134+
name="photoUrl"
135+
label={<Typography.Text strong>Image URL</Typography.Text>}
136+
rules={[{ whitespace: true }, { type: 'url', message: 'not valid url' }]}
137+
hasFeedback
138+
>
139+
<Input
140+
placeholder="https://www.example.com/photo.png"
141+
value={data.photoUrl}
142+
onChange={(event) => setData({ ...data, photoUrl: event.target.value })}
143+
/>
144+
</Form.Item>
128145
</Form>
129146
</Modal>
130147
);

datahub-web-react/src/app/entity/group/GroupInfoSideBar.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ export default function GroupInfoSidebar({ sideBarData, refetch }: Props) {
216216
urn,
217217
email,
218218
slack,
219+
photoUrl
219220
};
220221

221222
// About Text save

datahub-web-react/src/app/entity/group/GroupProfile.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export default function GroupProfile() {
8989

9090
// Side bar data
9191
const sideBarData = {
92-
photoUrl: undefined,
92+
photoUrl: data?.corpGroup?.editableProperties?.pictureLink || undefined,
9393
avatarName:
9494
data?.corpGroup?.properties?.displayName ||
9595
data?.corpGroup?.name ||

datahub-web-react/src/app/identity/group/GroupListItem.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export default function GroupListItem({ group, onDelete, selectRoleOptions, refe
5454
<GroupItemContainer>
5555
<Link to={`${entityRegistry.getEntityUrl(EntityType.CorpGroup, group.urn)}`}>
5656
<GroupHeaderContainer>
57-
<CustomAvatar size={32} name={displayName} />
57+
<CustomAvatar size={32} name={displayName} photoUrl={group?.editableProperties?.pictureLink || undefined}/>
5858
<div style={{ marginLeft: 16, marginRight: 16 }}>
5959
<div>
6060
<Typography.Text>{displayName}</Typography.Text>

datahub-web-react/src/graphql/group.graphql

+4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ query getGroup($urn: String!, $membersCount: Int!) {
1717
description
1818
slack
1919
email
20+
pictureLink
2021
}
2122
properties {
2223
displayName
@@ -201,6 +202,9 @@ query listGroups($input: ListGroupsInput!) {
201202
description
202203
email
203204
}
205+
editableProperties {
206+
pictureLink
207+
}
204208
memberCount: relationships(
205209
input: { types: ["IsMemberOfGroup", "IsMemberOfNativeGroup"], direction: INCOMING, start: 0, count: 1 }
206210
) {

0 commit comments

Comments
 (0)