Skip to content

Commit 669c67a

Browse files
authored
feat(docs/mlflow): update sample scripts to be compatible with edges/versioning (#12878)
1 parent 106d775 commit 669c67a

File tree

2 files changed

+30
-29
lines changed

2 files changed

+30
-29
lines changed

metadata-ingestion/examples/ai/dh_ai_client.py

+16-15
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
ChangeTypeClass,
1515
DataProcessInstanceRunResultClass,
1616
DataProcessRunStatusClass,
17+
EdgeClass,
1718
)
1819
from datahub.metadata.urns import (
1920
ContainerUrn,
@@ -255,7 +256,7 @@ def create_model(
255256
version_props = {
256257
"version": version_tag,
257258
"versionSet": str(version_set_urn),
258-
"sortId": "AAAAAAAA",
259+
"sortId": str(version_tag).zfill(10),
259260
}
260261

261262
# Add alias if provided
@@ -266,22 +267,10 @@ def create_model(
266267
models.VersionPropertiesClass, version_props
267268
)
268269

269-
# Create version set properties
270-
version_set_properties = models.VersionSetPropertiesClass(
271-
latest=str(model_urn),
272-
versioningScheme="ALPHANUMERIC_GENERATED_BY_DATAHUB",
273-
)
274-
275270
mcps = [
276271
self._create_mcp(
277272
str(model_urn), properties, "mlModel", "mlModelProperties"
278273
),
279-
self._create_mcp(
280-
str(version_set_urn),
281-
version_set_properties,
282-
"versionSet",
283-
"versionSetProperties",
284-
),
285274
self._create_mcp(
286275
str(model_urn), version_properties, "mlModel", "versionProperties"
287276
),
@@ -429,7 +418,13 @@ def add_input_datasets_to_run(self, run_urn: str, dataset_urns: List[str]) -> No
429418
entity_urn=run_urn,
430419
entity_type="dataProcessInstance",
431420
aspect_name="dataProcessInstanceInput",
432-
aspect=DataProcessInstanceInput(inputs=dataset_urns),
421+
aspect=DataProcessInstanceInput(
422+
inputs=[],
423+
inputEdges=[
424+
EdgeClass(destinationUrn=str(dataset_urn))
425+
for dataset_urn in dataset_urns
426+
],
427+
),
433428
)
434429
self._emit_mcps(mcp)
435430
logger.info(f"Added input datasets to run {run_urn}")
@@ -440,7 +435,13 @@ def add_output_datasets_to_run(self, run_urn: str, dataset_urns: List[str]) -> N
440435
entity_urn=run_urn,
441436
entity_type="dataProcessInstance",
442437
aspect_name="dataProcessInstanceOutput",
443-
aspect=DataProcessInstanceOutput(outputs=dataset_urns),
438+
aspect=DataProcessInstanceOutput(
439+
outputEdges=[
440+
EdgeClass(destinationUrn=str(dataset_urn))
441+
for dataset_urn in dataset_urns
442+
],
443+
outputs=[],
444+
),
444445
)
445446
self._emit_mcps(mcp)
446447
logger.info(f"Added output datasets to run {run_urn}")

metadata-ingestion/examples/ai/dh_ai_client_sample.py

+14-14
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,19 @@
9696
end_timestamp=1628580001000,
9797
)
9898
# Create datasets
99-
input_dataset_urn = client.create_dataset(
100-
platform="snowflake",
101-
name="iris_input",
102-
)
99+
input_dataset_urns = [
100+
client.create_dataset(
101+
platform="snowflake",
102+
name="iris_input",
103+
)
104+
]
103105

104-
output_dataset_urn = client.create_dataset(
105-
platform="snowflake",
106-
name="iris_ouptut",
107-
)
106+
output_dataset_urns = [
107+
client.create_dataset(
108+
platform="snowflake",
109+
name="iris_ouptut",
110+
)
111+
]
108112

109113
# Add run to experiment
110114
client.add_run_to_experiment(run_urn=run_urn, experiment_urn=experiment_urn)
@@ -125,10 +129,6 @@
125129
)
126130

127131
# Add input and output datasets to run
128-
client.add_input_datasets_to_run(
129-
run_urn=run_urn, dataset_urns=[str(input_dataset_urn)]
130-
)
132+
client.add_input_datasets_to_run(run_urn=run_urn, dataset_urns=input_dataset_urns)
131133

132-
client.add_output_datasets_to_run(
133-
run_urn=run_urn, dataset_urns=[str(output_dataset_urn)]
134-
)
134+
client.add_output_datasets_to_run(run_urn=run_urn, dataset_urns=output_dataset_urns)

0 commit comments

Comments
 (0)