fix wrong fixes

Author: anshbansal

datahub-web-react/src/app/entity/glossaryTerm/profile/AddRelatedTermsModal.tsx

@@ -104,7 +104,10 @@ function AddRelatedTermsModal(props: Props) {
         const newUrns = [...selectedUrns, urn];
         setSelectedUrns(newUrns);
         const selectedSearchOption = tagSearchOptions.find((option) => option.props.value === urn);
-        setSelectedTerms([...selectedTerms, { urn, component: <TermLabel name={selectedSearchOption?.props?.name} /> }]);
+        setSelectedTerms([
+            ...selectedTerms,
+            { urn, component: <TermLabel name={selectedSearchOption?.props?.name} /> },
+        ]);
     };
 
     // When a Tag or term search result is deselected, remove the urn from the Owners

datahub-web-react/src/app/entity/shared/containers/profile/sidebar/FormInfo/utils.ts

@@ -197,7 +197,7 @@ export function findPromptAssociation(prompt: FormPrompt, allPrompts: Array<Form
 // Get the prompts for a given form
 export function getPromptsForForm(formUrn: string, entityData: GenericEntityProperties | null) {
     const formAssociation = getFormAssociation(formUrn, entityData);
-    return formAssociation?.form?.inf?o.prompts || [];
+    return formAssociation?.form?.info?.prompts || [];
 }
 
 /*
@@ -279,7 +279,7 @@ export function isVerificationComplete(entityData: GenericEntityProperties | nul
 
 export function isFormVerificationType(entityData: GenericEntityProperties | null, formUrn: string) {
     const formAssociation = getFormAssociation(formUrn, entityData);
-    return formAssociation?.form?.inf?o.type === FormType.Verification;
+    return formAssociation?.form?.info?.type === FormType.Verification;
 }
 
 /*
@@ -317,6 +317,6 @@ export function getVerificationAuditStamp(entityData: GenericEntityProperties |
 export function getBulkByQuestionPrompts(formUrn: string, entityData: GenericEntityProperties | null) {
     const formAssociation = getFormAssociation(formUrn, entityData);
     return (
-        formAssociation?.form?.inf?o.prompts.filter((prompt) => !SCHEMA_FIELD_PROMPT_TYPES.includes(prompt.type)) || []
+        formAssociation?.form?.info?.prompts.filter((prompt) => !SCHEMA_FIELD_PROMPT_TYPES.includes(prompt.type)) || []
     );
 }

datahub-web-react/src/app/entity/shared/entityForm/EntityFormContextProvider.tsx

@@ -19,7 +19,7 @@ export default function EntityFormContextProvider({ children, formUrn }: Props)
     const { entityData, refetch: refetchEntityProfile, loading: profileLoading } = useEntityContext();
     const formAssociation = getFormAssociation(formUrn, entityData);
     const initialPromptId =
-        formAssociation?.form?.inf?o.promp?ts.filter((prompt) => !SCHEMA_FIELD_PROMPT_TYPES.includes(prompt.type))[0]
+        formAssociation?.form?.info?.prompts?.filter((prompt) => !SCHEMA_FIELD_PROMPT_TYPES.includes(prompt.type))[0]
             ?.id || null;
     const isVerificationType = isFormVerificationType(entityData, formUrn);
     const [formView, setFormView] = useState<FormView>(FormView.BY_ENTITY);

datahub-web-react/src/app/entity/shared/entityForm/Form.tsx

@@ -54,9 +54,9 @@ function Form({ formUrn }: Props) {
     if (!hasRendered) return <Loading />;
 
     const formAssociation = getFormAssociation(formUrn, entityData);
-    const title = formAssociation?.form?.inf?o.name;
+    const title = formAssociation?.form?.info?.name;
     const associatedUrn = formAssociation?.associatedUrn;
-    const description = formAssociation?.form?.inf?o.description;
+    const description = formAssociation?.form?.info?.description;
     const owners = formAssociation?.form.ownership?.owners;
 
     return (

datahub-web-react/src/app/entity/shared/entityForm/useShouldShowVerificationPrompt.ts

@@ -28,7 +28,7 @@ export default function useShouldShowVerificationPrompt(formUrn: string) {
     const { entityData } = useEntityData();
     const formVerification = getFormVerification(formUrn, entityData);
     const formAssociation = getFormAssociation(formUrn, entityData);
-    const formType = formAssociation?.form?.inf?o.type;
+    const formType = formAssociation?.form?.info?.type;
 
     return shouldShowVerificationPrompt({
         formType,

datahub-web-react/src/app/entity/shared/tabs/Dataset/Validations/contract/builder/utils.ts

@@ -9,12 +9,12 @@ export const createBuilderState = (contract?: DataContract | null): DataContract
         return {
             schema:
                 (contract?.properties?.schema?.length && {
-                    assertionUrn: contract?.properties?.schema[0]?.assertio?n.urn,
+                    assertionUrn: contract?.properties?.schema[0]?.assertion?.urn,
                 }) ||
                 undefined,
             freshness:
                 (contract?.properties?.freshness?.length && {
-                    assertionUrn: contract?.properties?.freshness[0]?.assertio?n.urn,
+                    assertionUrn: contract?.properties?.freshness[0]?.assertion?.urn,
                 }) ||
                 undefined,
             dataQuality:

datahub-web-react/src/app/entity/view/builder/ViewBuilder.tsx

@@ -32,7 +32,9 @@ export const ViewBuilder = ({ mode, urn, initialState, onSubmit, onCancel }: Pro
     const [createViewMutation] = useCreateViewMutation();
 
     const emitTrackingEvent = (viewUrn: string, state: ViewBuilderState, isCreate: boolean) => {
-        const filterFields = Array.from(new Set(state.definition?.filter?.filters?.map((filter) => filter.field) ?? []));
+        const filterFields = Array.from(
+            new Set(state.definition?.filter?.filters?.map((filter) => filter.field) ?? []),
+        );
         const entityTypes = Array.from(new Set(state.definition?.entityTypes ?? []));
 
         analytics.event({