Skip to content

Commit 6a0b886

Browse files
committed
removed un-necessary loop
1 parent a851531 commit 6a0b886

File tree

1 file changed

+6
-38
lines changed
  • metadata-ingestion/src/datahub/ingestion/source

1 file changed

+6
-38
lines changed

metadata-ingestion/src/datahub/ingestion/source/superset.py

+6-38
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@
8585
UpstreamLineageClass,
8686
)
8787
from datahub.sql_parsing.sqlglot_lineage import (
88-
ColumnLineageInfo,
89-
ColumnRef,
90-
DownstreamColumnRef,
9188
SqlParsingResult,
9289
create_lineage_sql_parsed_result,
9390
)
@@ -744,44 +741,15 @@ def generate_physical_dataset_lineage(
744741
# To generate column level lineage, we can manually decode the metadata
745742
# to produce the ColumnLineageInfo
746743
columns = dataset_response.get("result", {}).get("columns", [])
747-
cll: List[ColumnLineageInfo] = []
744+
fine_grained_lineages: List[FineGrainedLineageClass] = []
748745

749746
for column in columns:
750-
cll.append(
751-
ColumnLineageInfo(
752-
downstream=DownstreamColumnRef(
753-
table=datasource_urn,
754-
column=column.get("column_name", ""),
755-
native_column_type=column.get("type", ""),
756-
),
757-
upstreams=[
758-
ColumnRef(
759-
table=upstream_dataset,
760-
column=column.get("column_name", ""),
761-
)
762-
],
763-
logic=None,
764-
)
765-
)
766-
767-
fine_grained_lineages: List[FineGrainedLineageClass] = []
747+
column_name = column.get("column_name", "")
748+
if not column_name:
749+
continue
768750

769-
for cll_info in cll:
770-
downstream = (
771-
[
772-
make_schema_field_urn(
773-
cll_info.downstream.table, cll_info.downstream.column
774-
)
775-
]
776-
if cll_info.downstream
777-
and cll_info.downstream.table
778-
and cll_info.downstream.column
779-
else []
780-
)
781-
upstreams = [
782-
make_schema_field_urn(column_ref.table, column_ref.column)
783-
for column_ref in cll_info.upstreams
784-
]
751+
downstream = [make_schema_field_urn(datasource_urn, column_name)]
752+
upstreams = [make_schema_field_urn(upstream_dataset, column_name)]
785753
fine_grained_lineages.append(
786754
FineGrainedLineageClass(
787755
downstreamType=FineGrainedLineageDownstreamTypeClass.FIELD,

0 commit comments

Comments
 (0)