Skip to content

Commit 6a8de85

Browse files
committed
add external url button for ml entities for v2
1 parent 106d775 commit 6a8de85

File tree

14 files changed

+390
-367
lines changed

14 files changed

+390
-367
lines changed

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/mlmodel/mappers/MLModelGroupPropertiesMapper.java

+4
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ public MLModelGroupProperties apply(
5252
TimeStampToAuditStampMapper.map(context, mlModelGroupProperties.getLastModified()));
5353
}
5454

55+
if (mlModelGroupProperties.getExternalUrl() != null) {
56+
result.setExternalUrl(mlModelGroupProperties.getExternalUrl().toString());
57+
}
58+
5559
result.setCustomProperties(
5660
CustomPropertiesMapper.map(mlModelGroupProperties.getCustomProperties(), entityUrn));
5761

datahub-graphql-core/src/main/resources/entity.graphql

+8
Original file line numberDiff line numberDiff line change
@@ -10112,11 +10112,19 @@ type MLModelGroupProperties {
1011210112
"""
1011310113
customProperties: [CustomPropertiesEntry!]
1011410114

10115+
"""
10116+
URL to view this model group in the external system
10117+
"""
10118+
externalUrl: String
10119+
10120+
1011510121
"""
1011610122
Deprecated creation timestamp
1011710123
@deprecated Use the 'created' field instead
1011810124
"""
1011910125
createdAt: Long @deprecated(reason: "Use `created` instead")
10126+
10127+
1012010128
}
1012110129

1012210130
"""

datahub-web-react/src/app/entityV2/dataJob/DataJobEntity.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ const headerDropdownItems = new Set([
5555
EntityMenuItems.SHARE,
5656
EntityMenuItems.UPDATE_DEPRECATION,
5757
EntityMenuItems.ANNOUNCE,
58+
EntityMenuItems.EXTERNAL_URL,
5859
]);
5960

6061
/**

datahub-web-react/src/app/entityV2/dataProcessInstance/DataProcessInstanceEntity.tsx

+6-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,12 @@ export class DataProcessInstanceEntity implements Entity<DataProcessInstance> {
8080
// useUpdateQuery={useUpdateDataProcessInstanceMutation}
8181
getOverrideProperties={this.getOverridePropertiesFromEntity}
8282
headerDropdownItems={
83-
new Set([EntityMenuItems.UPDATE_DEPRECATION, EntityMenuItems.RAISE_INCIDENT, EntityMenuItems.SHARE])
83+
new Set([
84+
EntityMenuItems.UPDATE_DEPRECATION,
85+
EntityMenuItems.RAISE_INCIDENT,
86+
EntityMenuItems.SHARE,
87+
EntityMenuItems.EXTERNAL_URL,
88+
])
8489
}
8590
tabs={[
8691
{

datahub-web-react/src/app/entityV2/mlModel/MLModelEntity.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ const headerDropdownItems = new Set([
3535
EntityMenuItems.RAISE_INCIDENT,
3636
EntityMenuItems.ANNOUNCE,
3737
EntityMenuItems.LINK_VERSION,
38+
EntityMenuItems.EXTERNAL_URL,
3839
]);
3940

4041
/**

datahub-web-react/src/app/entityV2/mlModelGroup/MLModelGroupEntity.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ const headerDropdownItems = new Set([
2929
EntityMenuItems.SHARE,
3030
EntityMenuItems.UPDATE_DEPRECATION,
3131
EntityMenuItems.ANNOUNCE,
32+
EntityMenuItems.EXTERNAL_URL,
3233
]);
3334

3435
/**

datahub-web-react/src/graphql/dataProcessInstance.graphql

+1
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ fragment dataProcessInstanceFields on DataProcessInstance {
9090
key
9191
value
9292
}
93+
externalUrl
9394
}
9495
mlTrainingRunProperties {
9596
id

datahub-web-react/src/graphql/mlModelGroup.graphql

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ query getMLModelGroup($urn: String!) {
1313
time
1414
actor
1515
}
16+
externalUrl
1617
}
1718
...nonRecursiveMLModelGroupFields
1819
incoming: relationships(

metadata-models/src/main/pegasus/com/linkedin/ml/metadata/MLModelGroupProperties.pdl

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,15 @@ import com.linkedin.common.Time
55
import com.linkedin.common.VersionTag
66
import com.linkedin.common.CustomProperties
77
import com.linkedin.common.TimeStamp
8+
import com.linkedin.common.ExternalReference
89

910
/**
1011
* Properties associated with an ML Model Group
1112
*/
1213
@Aspect = {
1314
"name": "mlModelGroupProperties"
1415
}
15-
record MLModelGroupProperties includes CustomProperties, MLModelLineageInfo {
16+
record MLModelGroupProperties includes CustomProperties, MLModelLineageInfo, ExternalReference {
1617

1718
/**
1819
* Display name of the MLModelGroup

0 commit comments

Comments
 (0)